[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: make check for coreutils-7.2 fails
From: |
Jim Meyering |
Subject: |
Re: make check for coreutils-7.2 fails |
Date: |
Wed, 01 Apr 2009 17:03:14 +0200 |
Jim Meyering wrote:
> Sergei Steshenko wrote:
>> please find 'make check' screen output attached. There was no failure on the
>> same machine under the same OS (SUSE 10.3) for coreutils-7.1.
>>
>> FAIL: mv/i-3.log (exit: 1)
>> ==========================
> ...
>> + ls /dev/stdin
>> + mv f g
>> ./mv/i-3: line 38: /dev/stdin: Permission denied
>
> Thanks for the report.
> It failed because your /dev/stdin is not readable.
> The patch below makes is so that test will now be skipped in
> that situation.
>
>>From 72e01aeb6ec4999f3f6ce72fd35671a65cacfc69 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <address@hidden>
> Date: Wed, 1 Apr 2009 16:59:54 +0200
> Subject: [PATCH] tests: skip mv/i-3 if /dev/stdin is unreadable
>
> * tests/mv/i-3: Skip if /dev/stdin is unreadable.
> Reported by Sergei Steshenko.
> ---
> tests/mv/i-3 | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/tests/mv/i-3 b/tests/mv/i-3
> index d1f119c..738605b 100755
> --- a/tests/mv/i-3
> +++ b/tests/mv/i-3
> @@ -35,6 +35,9 @@ fail=0
> ls /dev/stdin >/dev/null 2>&1 \
> || skip_test_ 'there is no /dev/stdin file'
>
> +test -r /dev/stdin 2>&1 \
> + || skip_test_ '/dev/stdin is not readable'
> +
Oops.
No need for redirection:
+test -r /dev/stdin \