[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: don't use sticky-bit in install-C test
From: |
Jim Meyering |
Subject: |
Re: [PATCH] tests: don't use sticky-bit in install-C test |
Date: |
Sun, 19 Apr 2009 22:19:41 +0200 |
Aurelien Jarno wrote:
> tests/install/install-C uses mode 1755 to test install -C with
> non-permission bits set, that is the sticky bit set. Depending on the
> system, it is not always possible to set this bit for files (but
> allowed for directories) as non-root user. That's is the case for
> example on FreeBSD with an UFS filesystem.
>
> The patch below uses 2755 instead of 1755, which should work on all
> systems.
>
> * tests/install/install-C: Use 2755 instead of 1755 to test install
> -C with non-permission mode set.
Thank you.
Applied with a slightly less verbose comment.
>From e453e720b906a422dbaa7e3a40ee607fe4727912 Mon Sep 17 00:00:00 2001
From: Aurelien Jarno <address@hidden>
Date: Fri, 17 Apr 2009 18:10:04 +0200
Subject: [PATCH] tests: avoid failure of install-C test on FreeBSD UFS file
system
* tests/install/install-C: Use 2755 (set-gid), not 1755 (sticky),
to test install -C with non-permission mode bits set. At least on
FreeBSD with a UFS file system, a non-root user may not set the
sticky bit on a non-directory.
---
tests/install/install-C | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tests/install/install-C b/tests/install/install-C
index 9d0ec90..959bee1 100755
--- a/tests/install/install-C
+++ b/tests/install/install-C
@@ -26,7 +26,7 @@ skip_if_setgid_
mode1=0644
mode2=0755
-mode3=1755
+mode3=2755
fail=0
--
1.6.3.rc0.230.g3edd6