Re: [PATCH]: nl: deprecate --page-increment in favour of --line-increment

[Giuseppe Scrivano]

Thanks Kamil, yes, CHAR_MAX + 1 looks like a better choice.

Are there other comments?

Giuseppe


Kamil Dudka <address@hidden> writes:

> Hello Giuseppe,
>
> On Tue August 18 2009 12:47:06 Giuseppe Scrivano wrote:
>> diff --git a/src/nl.c b/src/nl.c
>> index 2deb314..ea7ebe6 100644
>> --- a/src/nl.c
>> +++ b/src/nl.c
>> @@ -150,7 +150,9 @@ static struct option const longopts[] =
>>    {"body-numbering", required_argument, NULL, 'b'},
>>    {"footer-numbering", required_argument, NULL, 'f'},
>>    {"starting-line-number", required_argument, NULL, 'v'},
>> -  {"page-increment", required_argument, NULL, 'i'},
>> +  {"line-increment", required_argument, NULL, 'i'},
>> +  /* FIXME: page-increment is deprecated, remove in dec-2011.  */
>> +  {"page-increment", required_argument, NULL, 'I'},
>
> what about use of CHAR_MAX + 1 instead of 'I'?
>
> Kamil