[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] dd conv=unblock: print final newline consistently
From: |
Eric Blake |
Subject: |
Re: [PATCH] dd conv=unblock: print final newline consistently |
Date: |
Thu, 10 Sep 2009 05:56:49 -0600 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Jim Meyering on 9/10/2009 4:26 AM:
> I don't like last-minute changes, but this seems safe, considering it's in
> an obscure corner of dd. Who actually uses dd's conv=unblock option?
> Of those precious few, who would notice the additional newline that
> dd-with-this-patch now prints for most combinations of output size
> and conversion block size?
>
> Comments welcome.
>
> BTW, this change makes GNU dd compatible with the vendor dd from at
> least Solaris 10 and FreeBSD.
Sounds like a good reason to me. And certainly more consistent with other
tools (I always get annoyed when Solaris sed refuses to operate on
trailing data that does not end in newline). I didn't see anything wrong
with the patch.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkqo6YEACgkQ84KuGfSFAYC+BgCeKIxsfxpeiA4bmsj5xxp3Ehlq
tCUAn3psN3/F+voDgodHFzKGuzUXariH
=IEeI
-----END PGP SIGNATURE-----