Re: [PATCH] maint: Use logical rather than bitwise operators on bools

[Pádraig Brady]

Jim Meyering wrote:

> Considering your arguments, I wonder if it's worthwhile to see
> how many of those changes are in parts of the code where decreased
> code size and fewer branches might make a difference.  Or go one
> better...

Here's list of size changes for reference:

$ find -type f -perm +111 -printf "%f\n" | sort |
> xargs size > logical.size
$ git show a037e838 | patch -p2 -R
$ make
$ find -newer chcon.c -type f -perm +111 -printf "%f\n" | sort |
> xargs size > bitwise.size
$ join -j6 -o 0,1.1,2.1 bitwise.size logical.size | column -t

filename   text   text
[          29026  29026
cat        37530  37434
chcon      48181  48181
chgrp      44920  44984
chmod      41217  41217
chown      46982  47046
cp         97798  97782
dd         45727  45711
df         57633  57697
dir        95685  95637
du         86464  86464
expand     20663  20647
expr       25536  25552
ginstall   88646  88646
id         22035  22035
ls         95685  95637
md5sum     27182  27198
mv         91160  91144
od         52127  52143
pathchk    18799  18831
pr         50974  51006
ptx        51030  51030
rm         46499  46499
sha1sum    30786  30802
sha224sum  36626  36642
sha256sum  36626  36642
sha384sum  91930  91962
sha512sum  91930  91962
sort       74379  74523
stty       52619  52283
tail       50009  49993
test       26014  26014
unexpand   21833  21737
vdir       95685  95637
wc         28847  28831

cheers,
Pádraig.