[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: system.h cleanups
From: |
Jim Meyering |
Subject: |
Re: system.h cleanups |
Date: |
Thu, 08 Oct 2009 17:30:39 +0200 |
Pádraig Brady wrote:
> Eric Blake wrote:
>>
>>>From 69b7a7ab900a043d6330b400659fb69a1aedde8e Mon Sep 17 00:00:00 2001
>> From: Eric Blake <address@hidden>
>> Date: Thu, 8 Oct 2009 08:13:02 -0600
>> Subject: [PATCH 1/3] maint: move timeout exit statuses
>>
>> * src/timeout.c (EXIT_TIMEDOUT, EXIT_CANCELED): Remove as
>> macros...
>> * src/system.h (EXIT_TIMEDOUT, EXIT_CANCELED): ...and provide as
>> enum values instead.
>
> I'm not against this but EXIT_TIMEDOUT is specific to timeout.
Good point.
I see little benefit to moving it out to system.h.
I'm all for the macro-to-enum conversion though.
How about just doing that and leaving them in timeout.c?
- system.h cleanups, Eric Blake, 2009/10/08
- Re: system.h cleanups, Jim Meyering, 2009/10/08
- Re: system.h cleanups, Pádraig Brady, 2009/10/08
- Re: system.h cleanups,
Jim Meyering <=
- Re: system.h cleanups, Eric Blake, 2009/10/08
- Re: system.h cleanups, Jim Meyering, 2009/10/08
- Re: system.h cleanups, Pádraig Brady, 2009/10/09
- Re: system.h cleanups, Eric Blake, 2009/10/09
- EXIT_CANCELED (was: system.h cleanups), Eric Blake, 2009/10/23
- Re: EXIT_CANCELED, Pádraig Brady, 2009/10/23
- Re: EXIT_CANCELED, Jim Meyering, 2009/10/23
- Re: EXIT_CANCELED, Eric Blake, 2009/10/23
- Re: EXIT_CANCELED, Jim Meyering, 2009/10/24
- Re: EXIT_CANCELED, Eric Blake, 2009/10/24