[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: clean up library dependencies
From: |
Eric Blake |
Subject: |
Re: clean up library dependencies |
Date: |
Fri, 09 Oct 2009 20:12:28 -0600 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Jim Meyering on 10/9/2009 2:56 PM:
>> For each library chunk, the comment lists something to grep for; any time we
>> add a new gnulib module that adds another library dependency, it should be
>> easier to grep for anyone that uses that function, and update the library
>> section accordingly.
>
> Nice change. Go ahead.
And with it checked in, I discovered that I missed stdbuf, and that gnulib
recommends a couple of other libraries. Since the build is broken without
the stdbuf fix, I'm pushing this, too.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkrP7YwACgkQ84KuGfSFAYCh0gCfUvGVAIl6hlEB+MMLFBmCexnP
XtoAoNM93ZxWkIIUl7UyeW99wZwt/ofh
=4b7U
-----END PGP SIGNATURE-----
>From 219f2f05382031f5d7e9532cc5768e79620bb90a Mon Sep 17 00:00:00 2001
From: Eric Blake <address@hidden>
Date: Fri, 9 Oct 2009 20:08:03 -0600
Subject: [PATCH] maint: touch up previous LDADD patch
* src/Makefile.am (stdbuf_LDADD): Add missing primer.
(hostname_LDADD, uname_LDADD): Add GETHOSTNAME_LIB.
* bootstrap.conf (gnulib_modules): Add uname.
---
bootstrap.conf | 1 +
src/Makefile.am | 5 +++++
2 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/bootstrap.conf b/bootstrap.conf
index 9cf3746..e9b198c 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -210,6 +210,7 @@ gnulib_modules="
sys_stat
timespec
tzset
+ uname
unicodeio
unistd-safer
unlink-busy
diff --git a/src/Makefile.am b/src/Makefile.am
index 56cd0d4..ed7cc86 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -166,6 +166,7 @@ sleep_LDADD = $(LDADD)
sort_LDADD = $(LDADD)
split_LDADD = $(LDADD)
stat_LDADD = $(LDADD)
+stdbuf_LDADD = $(LDADD)
stty_LDADD = $(LDADD)
su_LDADD = $(LDADD)
sum_LDADD = $(LDADD)
@@ -293,6 +294,10 @@ truncate_LDADD += $(LIBICONV)
pinky_LDADD += $(GETADDRINFO_LIB)
who_LDADD += $(GETADDRINFO_LIB)
+# for gethostname, uname
+hostname_LDADD += $(GETHOSTNAME_LIB)
+uname_LDADD += $(GETHOSTNAME_LIB)
+
$(PROGRAMS): ../lib/libcoreutils.a
# Get the release year from ../lib/version-etc.c.
--
1.6.5.rc1