[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] issue warnings for more missing optional libraries
From: |
Pádraig Brady |
Subject: |
Re: [PATCH] issue warnings for more missing optional libraries |
Date: |
Tue, 20 Oct 2009 00:06:08 +0100 |
User-agent: |
Thunderbird 2.0.0.6 (X11/20071008) |
Bruno Haible wrote:
> Pádraig Brady wrote:
>> configure: WARNING: libacl development library was not found or not
>> usable.
>> configure: WARNING: GNU coreutils will be built without ACL support.
>> configure: WARNING: libselinux was found but selinux/selinux.h is
>> missing.
>> configure: WARNING: GNU coreutils will be compiled without SELinux
>> support.
>> configure: WARNING: libattr development library was not found or not
>> usable.
>> configure: WARNING: GNU coreutils will be built without xattr support.
>> configure: WARNING: libcap development library was not found or not
>> usable.
>> configure: WARNING: GNU coreutils will be built without capability
>> support.
>> configure: WARNING: libgmp development library was not found or not
>> usable.
>> configure: WARNING: GNU coreutils will be built without GMP support
>
> I like it. Even more I like the configure files that print a summary of the
> most important decisions or findings at the end of the configuration, thus
> giving an opportunity to the user to re-configure with different --with or
> --enable options. (Given the size of the configure output, hardly anyone looks
> through it in its entirety.)
>
> It looks like this in mono:
>
> $ ./configure
> ...
> configure: creating ./config.status
> config.status: creating Makefile
> config.status: creating include/Makefile
> config.status: creating include/private/Makefile
> config.status: creating doc/Makefile
> config.status: executing depfiles commands
> config.status: executing default commands
>
> mcs source: $(top_srcdir)/mcs
> GC: included
> TLS: __thread
> SIGALTSTACK: no
> Engine: Building and using the JIT
> 2.0 Alpha: yes
> JNI support: IKVM Native
> libgdiplus: assumed to be installed
>
> Or similarly in GNU clisp:
>
> $ ./configure
> ...
> Configure findings:
> FFI: no (user requested: default)
> readline: yes (user requested: default)
> libsigsegv: no, consider installing GNU libsigsegv
>
> Especially for packages with many dependencies or with many configuration
> opportunities it would be useful.
>
> What do you think? Should we pursue this further?
Right, the verbose configure output is mostly noise to me at least,
and so a summary at the end would be nicer. Though that would be a bit of work,
and --quiet with appropriate WARNINGS isn't too bad.
Hmm it would be nice to be able to default to --quiet and have
the normal checking... messages output to config-msgs.log or something.
Anyway I'll check in the attached patch to coreutils, and would
appreciate if someone could apply the gnulib one.
cheers,
Pádraig.
>From b0bccf1c59f3823a67eff770cad8fc280406c13e Mon Sep 17 00:00:00 2001
From: =?utf-8?q?P=C3=A1draig=20Brady?= <address@hidden>
Date: Mon, 19 Oct 2009 11:12:40 +0100
Subject: [PATCH] maint: issue warnings for more missing optional libraries
* README-hacking: Suggest to use ./configure --quiet so that
any warnings are easily noticed.
* m4/gmp.m4 (cu_GMP): Warn if libgmp is not used.
* m4/jm-macros.m4 (coreutils_MACROS): Normalize the libcap warning.
* m4/xattr.m4 (gl_FUNC_XATTR): Warn if libattr not used.
---
README-hacking | 2 +-
m4/gmp.m4 | 4 +++-
m4/jm-macros.m4 | 3 ++-
m4/xattr.m4 | 2 ++
4 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/README-hacking b/README-hacking
index daaa4b1..c5d3128 100644
--- a/README-hacking
+++ b/README-hacking
@@ -35,7 +35,7 @@ which are extracted from other source packages:
And there you are! Just
- $ ./configure #[--enable-gcc-warnings]
+ $ ./configure --quiet #[--enable-gcc-warnings]
$ make
$ make check
diff --git a/m4/gmp.m4 b/m4/gmp.m4
index 8e71120..170c2a1 100644
--- a/m4/gmp.m4
+++ b/m4/gmp.m4
@@ -30,7 +30,9 @@ AC_DEFUN([cu_GMP],
LIB_GMP=$ac_cv_search___gmpz_init
AC_DEFINE([HAVE_GMP], [1],
[Define if you have GNU libgmp (or replacement)])
- }])
+ }],
+ [AC_MSG_WARN([libgmp development library was not found or not usable.])
+ AC_MSG_WARN([AC_PACKAGE_NAME will be built without GMP support.])])
LIBS=$cu_saved_libs
fi
])
diff --git a/m4/jm-macros.m4 b/m4/jm-macros.m4
index f4d43f1..398cd47 100644
--- a/m4/jm-macros.m4
+++ b/m4/jm-macros.m4
@@ -118,7 +118,8 @@ AC_DEFUN([coreutils_MACROS],
if test "X$enable_libcap" = "Xyes"; then
AC_MSG_ERROR([libcap library was not found or not usable])
else
- AC_MSG_WARN([libcap library was not found or not usable, support for
libcap will not be built])
+ AC_MSG_WARN([libcap library was not found or not usable.])
+ AC_MSG_WARN([AC_PACKAGE_NAME will be built without capability
support.])
fi
fi
else
diff --git a/m4/xattr.m4 b/m4/xattr.m4
index 878e86b..900789e 100644
--- a/m4/xattr.m4
+++ b/m4/xattr.m4
@@ -22,6 +22,8 @@ AC_DEFUN([gl_FUNC_XATTR],
use_xattr=1
else
use_xattr=0
+ AC_MSG_WARN([libattr development library was not found or not usable.])
+ AC_MSG_WARN([AC_PACKAGE_NAME will be built without xattr support.])
fi
AC_DEFINE_UNQUOTED([USE_XATTR], [$use_xattr],
[Define if you want extended attribute support.])
--
1.6.2.5
>From fefef6da3fd0b2cbcc1a29467c4aa2d869fcbc54 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?P=C3=A1draig=20Brady?= <address@hidden>
Date: Mon, 19 Oct 2009 10:10:05 +0100
Subject: [PATCH] acl: warn if ACL support is not detected
m4/acl.m4 (gl_FUNC_ACL): Output a warning if ACL support is not found.
---
m4/acl.m4 | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/m4/acl.m4 b/m4/acl.m4
index 5340e2e..784f4ea 100644
--- a/m4/acl.m4
+++ b/m4/acl.m4
@@ -116,6 +116,9 @@ int type = ACL_TYPE_EXTENDED;]],
fi
if test "x$enable_acl$use_acl" = "xyes0"; then
AC_MSG_ERROR([ACLs enabled but support not detected])
+ elif test "x$enable_acl$use_acl" = "xauto0"; then
+ AC_MSG_WARN([libacl development library was not found or not usable.])
+ AC_MSG_WARN([AC_PACKAGE_NAME will be built without ACL support.])
fi
fi
AC_SUBST([LIB_ACL])
--
1.6.2.5