bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: stat(1) on Solaris 9


From: Eric Blake
Subject: Re: stat(1) on Solaris 9
Date: Fri, 23 Oct 2009 06:30:29 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Jim Meyering on 10/23/2009 6:19 AM:
>> * src/ln.c (do_link): Adjust comment to avoid rule.
>> * src/stat.c (do_stat): Likewise.
>> * src/touch.c (main): Likewise.
> 
> Thanks!  At first I was going to object, thinking you'd
> changed code formatting, rather than code-in-comment.

It caught me by surprise, too, when I ran the syntax check, since I knew I
had just recently fixed those very files.

> This looks fine.  Obfuscating code in comments is much
> better than exempting those entire files.
> 
>> +    @re='stat '':|&l?stat\>'                                        \
> 
> How about \<l?stat, so we don't mistakenly match something like
> "not_stat :"?

Done.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkrhoeUACgkQ84KuGfSFAYCNfgCgxwGQJ5VVbe/Q35V3eBmnbdnu
AkoAoJ3ngNtdq+S5h9rL1IBp8KWJ20RW
=fICy
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]