|
From: | Pádraig Brady |
Subject: | Re: env+nice, one bug fix, two test corrections |
Date: | Wed, 28 Oct 2009 22:22:59 +0000 |
User-agent: | Thunderbird 2.0.0.6 (X11/20071008) |
Eric Blake wrote: > --- a/tests/misc/nohup > +++ b/tests/misc/nohup > @@ -64,6 +64,21 @@ test -f nohup.out && fail=1 > rm -f nohup.out err > # ---------------------- > > +# Bug present through coreutils 8.0: failure to print advisory message > +# to stderr must be fatal. Requires stdout to be terminal. > +if test -w /dev/full && test -c /dev/full; then > +( > + exec >/dev/tty > + test -t 1 || exit 0 > + nohup true 2> /dev/full > + test $? = 125 || fail=1 > + test -f nohup.out || fail=1 > + test -s nohup.out && fail=1 I'd run something other than `true` so that the `test -s` checking whether it was run or not can fail. Otherwise it looks good. thanks, Pádraig.
[Prev in Thread] | Current Thread | [Next in Thread] |