[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] maint: move definitions from maint.mk to dist-check.mk
From: |
Jim Meyering |
Subject: |
[PATCH] maint: move definitions from maint.mk to dist-check.mk |
Date: |
Sun, 13 Dec 2009 10:52:23 +0100 |
This goes with today's gnulib change:
>From 02919661750c535e67fd204345e2ac4982c70887 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sun, 13 Dec 2009 10:35:49 +0100
Subject: [PATCH] maint: move definitions from maint.mk to dist-check.mk
* dist-check.mk (null_AM_MAKEFLAGS): Define here, not in maint.mk.
(built_programs): Likewise.
(my-distcheck): Move comments to...
(coreutils-path-check): ...the code they refer to.
Remove obsolete comments.
(null_AM_MAKEFLAGS): Add gperf, even though it's not used here.
* gnulib: Update to latest, for fixed maint.mk.
---
dist-check.mk | 32 ++++++++++++++++++++------------
gnulib | 2 +-
2 files changed, 21 insertions(+), 13 deletions(-)
diff --git a/dist-check.mk b/dist-check.mk
index 0299f51..87dfc40 100644
--- a/dist-check.mk
+++ b/dist-check.mk
@@ -9,6 +9,8 @@ tmpdir = $(abs_top_builddir)/tests/torture
t=$(tmpdir)/$(PACKAGE)/test
pfx=$(t)/i
+built_programs = $$(cd src && MAKEFLAGS= $(MAKE) -s built_programs.list)
+
# More than once, tainted build and source directory names would
# have caused at least one "make check" test to apply "chmod 700"
# to all directories under $HOME. Make sure it doesn't happen again.
@@ -71,6 +73,13 @@ define my-instcheck
}
endef
+# The hard-linking for-loop below ensures that there is a bin/ directory
+# full of all of the programs under test (except the ones that are required
+# for basic Makefile rules), all symlinked to the just-built "false" program.
+# This is to ensure that if ever a test neglects to make PATH include
+# the build srcdir, these always-failing programs will run.
+# Otherwise, it is too easy to test the wrong programs.
+# Note that "false" itself is a symlink to true, so it too will malfunction.
define coreutils-path-check
{ \
echo running coreutils-path-check; \
@@ -101,18 +110,17 @@ define coreutils-path-check
}
endef
-# Use -Wformat -Werror to detect format-string/arg-list mismatches.
-# Also, check for shadowing problems with -Wshadow, and for pointer
-# arithmetic problems with -Wpointer-arith.
-# These CFLAGS are pretty strict. If you build this target, you probably
-# have to have a recent version of gcc and glibc headers.
-# The hard-linking for-loop below ensures that there is a bin/ directory
-# full of all of the programs under test (except the ones that are required
-# for basic Makefile rules), all symlinked to the just-built "false" program.
-# This is to ensure that if ever a test neglects to make PATH include
-# the build srcdir, these always-failing programs will run.
-# Otherwise, it is too easy to test the wrong programs.
-# Note that "false" itself is a symlink to true, so it too will malfunction.
+# Use this to make sure we don't run these programs when building
+# from a virgin tgz file, below.
+null_AM_MAKEFLAGS ?= \
+ ACLOCAL=false \
+ AUTOCONF=false \
+ AUTOMAKE=false \
+ AUTOHEADER=false \
+ GPERF=false \
+ LIBTOOL=false \
+ MAKEINFO=false
+
ALL_RECURSIVE_TARGETS += my-distcheck
my-distcheck: $(DIST_ARCHIVES) $(local-check)
$(MAKE) syntax-check
diff --git a/gnulib b/gnulib
index a3984e0..5016c20 160000
--- a/gnulib
+++ b/gnulib
@@ -1 +1 @@
-Subproject commit a3984e06bca84a7654624dd754a7c4c7a5a39a59
+Subproject commit 5016c2066bfca00f5a24e0d2abaca25f0fce75fb
--
1.6.6.rc2.275.g51e2d
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [PATCH] maint: move definitions from maint.mk to dist-check.mk,
Jim Meyering <=