Re: expr say "non integer argument"

[Eric Blake]

According to address@hidden on 2/18/2010 6:54 AM:
> EB> jidanni, it would be a two-line patch to expr.c.  Would you care to write
> EB> such a patch, rather than just complaining?
> 
> It would be much more efficient for me to just play the role of the bug
> reporter here.... trust me. Thanks.

You are giving up too easily.  Your bug reports would go a LOT further if
you would show some effort behind them.  What's so hard about:

sed -i 's/non-numeric/non-integer/' src/expr.c

It results in this diff:

diff --git a/src/expr.c b/src/expr.c
index 048c596..1ebb4b9 100644
--- a/src/expr.c
+++ b/src/expr.c
@@ -787,7 +787,7 @@ eval4 (bool evaluate)
       if (evaluate)
         {
           if (!toarith (l) || !toarith (r))
-            error (EXPR_INVALID, 0, _("non-numeric argument"));
+            error (EXPR_INVALID, 0, _("non-integer argument"));
           if (fxn != multiply && mpz_sgn (r->u.i) == 0)
             error (EXPR_INVALID, 0, _("division by zero"));
           ((fxn == multiply ? mpz_mul
@@ -824,7 +824,7 @@ eval3 (bool evaluate)
       if (evaluate)
         {
           if (!toarith (l) || !toarith (r))
-            error (EXPR_INVALID, 0, _("non-numeric argument"));
+            error (EXPR_INVALID, 0, _("non-integer argument"));
           (fxn == plus ? mpz_add : mpz_sub) (l->u.i, l->u.i, r->u.i);
         }
       freev (r);


Now all that's lacking is a changelog-style commit message, and you're done.

-- 
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden

signature.asc
Description: OpenPGP digital signature