[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#9086: [PATCH] ls --color case insensitive extension matching
|
From: |
Eric Blake |
|
Subject: |
bug#9086: [PATCH] ls --color case insensitive extension matching |
|
Date: |
Wed, 27 Jul 2011 13:25:52 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.11 |
On 07/26/2011 02:33 PM, marcel partap wrote:
Here's a patch. Adds STRCASEEQ_LEN macro for case insensitive extension
matching.
#regards/marcel.
Your patch would make the new behavior unconditional. But I like case
sensitivity, and think that case insensitivity should be an opt-in
process that I request, with coordination between dircolors to generate
a new string for LS_COLORS to be honored by ls. Furthermore, the patch
is lacking in NEWS, documentation, and testsuite coverage.
Additionally, you should be aware that strncasecmp() has undefined
behavior in non-C multibyte locales. It would probably be better to use
c_strncasecmp(), so that you are guaranteed defined behavior regardless
of the current locale.
Would you care to tackle those additional issues? And are you set up
for copyright assignment, since the patch will probably be non-trivial
by that point in time?
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org