[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#6683: mktemp foo.XXXXXXXXXXX is not sufficiently random
From: |
Paul Eggert |
Subject: |
bug#6683: mktemp foo.XXXXXXXXXXX is not sufficiently random |
Date: |
Mon, 08 Aug 2011 00:39:30 -0700 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.18) Gecko/20110617 Thunderbird/3.1.11 |
On 08/07/2011 10:04 AM, Jim Meyering wrote:
> Yes, please do.
OK, thanks, I installed the one-line change as change to the diff.
This is the first time I've updated a diff file in a while (ever?),
so I hope I did it right. I'm marking the bug done.
>From 8e2767a3f0c279d355f067e53be2c63173959eb1 Mon Sep 17 00:00:00 2001
From: Paul Eggert <address@hidden>
Date: Mon, 8 Aug 2011 00:29:46 -0700
Subject: [PATCH] mktemp: stir in enough entropy (Bug#6683)
* gl/lib/tempname.c.diff (gen_tempname_len):
Use x_suffix_len bytes' worth of entropy, not 8 bytes.
---
gl/lib/tempname.c.diff | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gl/lib/tempname.c.diff b/gl/lib/tempname.c.diff
index fcacf53..3e30c97 100644
--- a/gl/lib/tempname.c.diff
+++ b/gl/lib/tempname.c.diff
@@ -100,7 +100,7 @@ index 2da5afe..562955a 100644
- }
-#endif
- value += random_time_bits ^ __getpid ();
-+ rand_src = randint_all_new (NULL, 8);
++ rand_src = randint_all_new (NULL, x_suffix_len);
+ if (! rand_src)
+ return -1;
--
1.7.4.4