|
From: | Paul Eggert |
Subject: | bug#11424: coreutils: split tests hang on /dev/zero on GNU/Hurd |
Date: | Mon, 07 May 2012 00:52:11 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
On 05/07/2012 12:46 AM, Jim Meyering wrote:
+ + /* stat.st_size is valid only for regular files. For others, use 0. */ + file_size = S_ISREG (stat_buf.st_mode) ? stat_buf.st_size : 0;
Is it right to use 0 there, for non-regular files? Won't later code compute incorrect sizes in that case? Also, as a nit, stat.st_size is also valid for SHM and TMO files (this was in the patch I just sent).
[Prev in Thread] | Current Thread | [Next in Thread] |