[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#17035: [PATCH] chmod -c -R produces errors with special permissions
From: |
Jim Meyering |
Subject: |
bug#17035: [PATCH] chmod -c -R produces errors with special permissions |
Date: |
Tue, 18 Mar 2014 16:36:37 -0700 |
On Tue, Mar 18, 2014 at 11:45 AM, Pádraig Brady <address@hidden> wrote:
> diff --git a/tests/chmod/c-option.sh b/tests/chmod/c-option.sh
...
> +# This should never warn, but in did when special
> +# bits are set on b (the common case under test)
> +chmod -c -R g+w a 2>err
> +test -s err && fail=1
Thanks for adding the test.
I have a small preference for using compare-vs-/dev/null rather than
"test -s," since the former will print the unexpected output in the log,
while the latter won't. So maybe this instead?
compare /dev/null err || fail=1