bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#17149: shred - tape data


From: Paul Eggert
Subject: bug#17149: shred - tape data
Date: Thu, 03 Apr 2014 21:53:03 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0

Pádraig Brady wrote:
                    if (! INT_ADD_OVERFLOW (size, size_incr))
                      size += size_incr;
+                  else
+                    size = OFF_T_MAX;

A clearer way to write that would be:

   size += MIN (size_incr, OFF_T_MAX - size);

Otherwise it looks good.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]