bug#29989: coreutils-8.29 make test fail

[Pádraig Brady]

On 05/01/18 07:16, GS wrote:
> Good day
> 
> please find enclosed test-suit.log file as requested and my terminal file.

For future ref, terminal file is redundant when we have the test-suite.log

The pertinent part of your log is:

FAIL: tests/df/df-symlink
=========================
++ df --out=source .
++ tail -n1
+ disk=/home/gerald/.Private
+ ln -s /home/gerald/.Private symlink
+ df --out=source,target /home/gerald/.Private
+ df --out=source,target symlink
+ compare exp out
+ compare_dev_null_ exp out
+ test 2 = 2
+ test xexp = x/dev/null
+ test xout = x/dev/null
+ return 2
+ case $? in
+ compare_ exp out
+ diff -u exp out
++ df --output=source
++ wc -l
++ grep -F /home/gerald/.Private
+ test 1 = 1
+ df --out=source,target .
+ compare exp out
+ compare_dev_null_ exp out
+ test 2 = 2
+ test xexp = x/dev/null
+ test xout = x/dev/null
+ return 2
+ case $? in
+ compare_ exp out
+ diff -u exp out
--- exp 2018-01-04 23:03:10.564298807 -0800
+++ out 2018-01-04 23:03:10.572299027 -0800
@@ -1,2 +1,2 @@
-Filesystem     Mounted on
-/dev/sda2      /
+Filesystem            Mounted on
+/home/gerald/.Private /home/gerald
+ fail=1
+ test 1 = 1
+ dump_mount_list_
+ cat /proc/self/mountinfo
...
25 0 8:2 / / rw,relatime shared:1 - ext4 /dev/sda2 
rw,errors=remount-ro,data=ordered
254 25 0:46 / /home/gerald rw,nosuid,nodev,relatime shared:250 - ecryptfs 
/home/gerald/.Private
...



Assaf Gordon also noticed this issue. His log was:

Ubuntu 16.04:

FAIL: tests/df/df-symlink
=========================
[...]
--- exp 2017-12-21 18:43:36.003465017 -0700
+++ out 2017-12-21 18:43:36.011465116 -0700
@@ -1,2 +1,2 @@
Filesystem     Mounted on
-/dev/sdb2      /tmp
+/dev/sdb2      /scratch

log attached.

This is a false positive, but the test could probably be improved:
on this machine /dev/sdb2 is bound-mount in /etc/stab like so:
===
/dev/sdb        /scratch  ext4   relatime,user_xattr  0    2
/scratch/tmp    /tmp      none   defaults,bind        0    0
===


We'll look into it.

> ps: a recommended procedure to use the .sig file to verify the .tar file
> could be added to the package.

Note the release announcement does have instructions:
  https://lists.gnu.org/archive/html/coreutils-announce/2017-12/msg00000.html
I guess you mean to have a README with this info in 
ftp://ftp.gnu.org/pub/gnu/coreutils/ etc.

BTW I see that the latest wget now supports auto handling .sig file when 
downloading:
https://twitter.com/ruehsen/status/947819437356474369

thanks!
Pádraig