bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#34488: Add sort --limit, or document workarounds for sort|head error


From: Assaf Gordon
Subject: bug#34488: Add sort --limit, or document workarounds for sort|head error messages
Date: Mon, 25 Feb 2019 18:15:03 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

Hello,

Thanks for all comments.

On 2019-02-24 11:33 a.m., Paul Eggert wrote:
Thanks for doing all that. Although Pádraig is not enthusiastic about a shortcut like -p, I'm a bit warmer to it, as it's an important special case to fix a wart in POSIX. No big deal either way.

For now I kept "-p", can be removed later of course.
The first patch includes Pádraig's recent suggestions (slightly modified).

The documentation should mention that SIGCHLD is special [...]

The documentation should say what happens if mutually-contradictory options are specified, [...]

The documentation should echo this suggestion in <http://pubs.opengroup.org/onlinepubs/9699919799/functions/exec.html>:

I've added those, and I welcome all improvements suggestion to grammar/phrasing/etc.

> There should be options --block-signal[=SIG], --unblock-signal[=SIG],
> and --setmask-signal[=SIG] that affect the signal mask, which is also
> inherited by the child. These can be implemented via pthread_sigmask.

The second patch adds these new options (separated to ease review).
As for documentation - I'm not sure what to add beyond the basic
option description. When should these be used?

A third small patch adds "env ---list-signal-actions" and
"env --list-blocked-signals" - to ease diagnostics.
Might be worth adding for completeness (e.g., for users who
need to somehow know if SIGPIPE is being ignored by the shell
or not):

    $ ( trap '' PIPE && src/env --list-signal-actions )
    PIPE       (13): ignore

Comments very welcomed,
 - assaf



Attachment: 0001-env-new-options-p-default-signal-SIG-ignore-signal-S.patch
Description: Text Data

Attachment: 0002-env-add-block-unblock-setmask-signal-SIG-options.patch
Description: Text Data

Attachment: 0003-env-add-list-blocked-signals-list-signal-actions-opt.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]