Re: Patch for making CommitID configurable

[Mark D. Baushke]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Derek Price <derek@ximbiot.com> writes:

> Just a note, I already agreed to commit Peter's patch some days ago in
> this thread, with the change that I was going to make the default
> behavior leaving commitID enabled, with his config key able to turn it
> off, pending lack of objections from the other developers and general
> agreement from users.

Hmmm... I don't think that would avoid having some commitid deltas in
the repository if the user wants to make use of the switch.

I was under the impression that Peter's patch adds a new UseCommitID
keyword into the CVSROOT/config file. This file has an initial creation
via 'cvs init' and will not have a commitid in the delta right now
(I have been meaning to ask if that is a bug or a feature).

If an administrator goes ahead and modifies a checked-out copy of
CVSROOT/config to add UseCommitID=no and commits it, then the delta for
that change will have a commitid in it.

If the intent of the administrator was to avoid having ANY deltas in the
repository with the commitid newphrase, then this one file will be an
exception.

So, if you wish to default to UseCommitID=yes for CVS, then you probably
also need to provide a 'cvs admin' switch that will remove commitid
phrases for given revisions of files.

Is avoiding commitid really worth all of this trouble? If so, then
allowing the administrator to rip out any uses of it after the fact also
seems needed.

Comments on the patch... if UseCommitID=no I would have expected that to
just deal with the generation of new commitid keywords, not the display
of log messages or versions that have it. So, I would have expected it
to control import.c and rcs.c output, but I would NOT have expected it
to be quiet if it finds a commitid field present in the delta. I would
also expect that the new .commitid tag processing would work if there
were delta records with a commitid in them regardless of the UseCommitID
value.

Summary: I can see the (marginal) utility of adding a way to avoid
creating new commitid tags in the RCS files of the CVS repository. I can
not see any benefit in supressing new CVS functionality for revisions of
files that use them.

Therefore, I object to Peter's patch as provided.

        -- Mark
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)

iD8DBQFCb+iZ3x41pRYZE/gRAiNRAKCEz0zm80/FNdGTx+LmgKSYUTTqzQCeOv9S
KteQb5obhzNsKqWzHjplWE4=
=zJKj
-----END PGP SIGNATURE-----