Re: [Bug-ddrescue] Fill mode does not work if input_position is greater than file size

[Christian Franke]

Antonio Diaz Diaz wrote:
> Christian Franke wrote:
> ...
>
> > > # ddrescue -F - fill_file file.img file.log
> >
> > This does not work because file.log records the original offset from 
> > bad_disk, not the resulting offset in file.img.
>
> Oops! You are right, but I can't use the -i option to solve this 
> because it is already used as (surprise) a starting position for the 
> input file.

Why not?

Handling the offset(opos - ipos) in fillbook class like it is already 
done in rescuebook would fix the problem.

This IMO would not break any practical application of fill mode.

I would suggest to move the "offset" member to base class. It would be 
always necessary, because the logfile does not record the outfile positions.


> Storing the offset in the logfile isn't an option either, because the 
> same files can be used several times with different offsets.

Yes, several invocations for the same out+logfile with different 
positions make sense, but only if the offset(opos - ipos) is always 
identical. Otherwise the resulting outfile is typically useless.


> Just now I can't think out any elegant solution, but this need to be 
> solved soon.

Yes, as this bug makes fill mode useless and dangerous if -i and -o of 
the rescue run differ.

Regards,
   Christian