Re: [Bug-ddrescue] [PATCH] Add device_id() for Cygwin

[Antonio Diaz Diaz]

Hello Christian,

Christian Franke wrote:
> the attached patch adds device_id() for Cygwin. Tested with 32- and 
> 64-bit Cygwin.
> Should be safe to include in 1.21 as no other platform is affected.

Thanks for the patch.

The patch is mostly ok but, isn't there a safer way of implementing this 
for Cygwin? I don't like neither the use of an union nor the unverified 
access to the 'raw' member in the union 
('data.raw[data.desc.VendorIdOffset]', for example). Most probably this 
will cause problems with '-fstrict-aliasing', or even an invalid memory 
access.


Best regards,
Antonio.