[Bug-dejagnu] Problems testing binutils with DejaGnu 1.5.3+

[Andrey ``Bass'' Shcheglov]

Hello,

I'm testing binutils (git master) with overridden RUNTESTFLAGS in order
to produce XML reports:

> $ make -k RUNTESTFLAGS='--all --xml' check

This ran fine with runtest 1.5.1, but produces the following error with
runtest 1.5.3 and 1.6:

> Making a new site.exp file...
> srcdir=`cd . && pwd`; export srcdir; \
> r=`pwd`; export r; \
> LC_ALL=C; export LC_ALL; \
> EXPECT=expect; export EXPECT; \
> runtest=runtest; \
> if /bin/bash -c "$runtest --version" > /dev/null 2>&1; then \
>   CC="gcc" CC_FOR_BUILD="gcc" \
>   CC_FOR_TARGET="gcc" CFLAGS_FOR_TARGET="-g -O2" \
>     $runtest --tool binutils --srcdir ${srcdir}/testsuite \
>         --all --xml; \
> else echo "WARNING: could not find \`runtest'" 1>&2; :;\
> fi
> WARNING: Couldn't find tool init file
> couldn't open "/home/.../binutils/testsuite": illegal operation on a directory
> Makefile:1322: recipe for target 'check-DEJAGNU' failed
>     while executing
> "open [file join $outdir $xml_file_name] w"
>     (procedure "open_logs" line 19)
>     invoked from within
> "open_logs"
>     (file "/usr/share/dejagnu/runtest.exp" line 1223)
> make[5]: *** [check-DEJAGNU] Error 1
> make[4]: *** [check-am] Error 2
> make[3]: *** [check-recursive] Error 1
> make[2]: *** [check] Error 2
> make[1]: *** [check-binutils] Error 2
> make: *** [do-check] Error 2

Depending on DejaGnu version (1.5.3 vs 1.6), the actual Linux distribution and 
the software package being tested, the error message may be slightly different:
> can't read "optarg": no such variable while executing "set
> xml_file_name $optarg" ("for" body line 190) invoked from within "for
> { set i 0 } { $i < $argc } { incr i } { set option [ lindex $argv $i ]
> # make all options have two hyphens switch -glob -- $option { ..."
> (file "/usr/share/dejagnu/runtest.exp" line 987) 
In order to work around the issue, I had to add an explicit argument to
the --xml option of runtest 1.5.3+ (ignored by runtest 1.5.1):

> $ make -k RUNTESTFLAGS='--all --xml=testsuite.xml' check

Binutils team confirms 
<https://sourceware.org/ml/binutils/2017-08/msg00122.html> this is indeed a 
DejaGnu issue.

The issue can be reproduced using even the minimal DejaGnu testsuite, e. g.: 
<https://github.com/Naduxa/dejagnu-hello>

Regards,
Andrey.