[Bug-ed] git related bug when using ed as $EDITOR on OS X Mavericks & Yosemite

[Steven Terpe]

gnu-ed 1.10 crashes git commit editor on OS X (git version doesn’t seem to matter but can be duplicated using both Apple Git-50 (1.9.3) and compiling latest v2.2.1 git from source.

Steps to reproduce:

compile gnu-ed on OSX

export EDITOR=/path/to/ed

enter a git repo

touch or edit file foo.txt

git add foo.txt

git commit 

//git calls the $EDITOR, which is gnu ed 

319

(After the file loads with the length

type something that generates any error like)

Add a file.

?

# Whoops! I made a mistake!

0a

Add a file.

.

wq

error: There was a problem with the editor '/Users/sterpe/bin/ed'.

Please supply the message using either -m or -F option.

//session transcript

18:22:41 [1519\0] <address@hidden:~> λ echo $EDITOR

/Users/sterpe/bin/ed

18:22:46 [1520\0] <address@hidden:~> λ cd .home/

18:22:59 [1521\0:yosemite] <address@hidden:~/.home> λ \

  git add .profile

18:23:05 [1522\0:yosemite] <address@hidden:~/.home> λ git commit

319

Add a file. 

?

0a

Add a file.

.

wq

331

error: There was a problem with the editor '/Users/sterpe/bin/ed'.

Please supply the message using either -m or -F option.

18:23:21 [1523\1:yosemite] <address@hidden:~/.home> λ 

The OS X system /bin/ed (BSD) does not have this behavior.  I.e., git doesn’t crash, saves the commit message without error.

Right now my solution is to set EDITOR=/bin/ed and use GNU ed everywhere else, but would love to find out what’s going on with this.

Best,

Steve