Re: [bugs #12064] make distclean deletes a distributed file

[Martin Buchholz]

I cvs'ed the distribution and
followed the instructions in README-CVS (for the first time).

Unfortunately, I couldn't perform my test, because
configure; make distclean
failed as follows

make[1]: Entering directory `/home/martin/src/findutils/findutils/gnulib'
Making distclean in m4
/home/martin/src/findutils/findutils/gnulib/m4
make[2]: Entering directory `/home/martin/src/findutils/findutils/gnulib/m4'
Makefile:289: *** missing separator.  Stop.
make[2]: Leaving directory `/home/martin/src/findutils/findutils/gnulib/m4'
make[1]: *** [distclean-recursive] Error 1
make[1]: Leaving directory `/home/martin/src/findutils/findutils/gnulib'


Looking at gnulib/m4/Makefile.in, I see:

.PHONY: all all-am check check-am clean clean-generic distclean \
        distclean-generic distdir dvi dvi-am info info-am install \
        install-am install-data install-data-am install-exec \
        install-exec-am install-info install-info-am install-man \
        install-strip installcheck installcheck-am installdirs \
        maintainer-clean maintainer-clean-generic mostlyclean \
        mostlyclean-generic pdf pdf-am ps ps-am uninstall uninstall-am \
        uninstall-info-am

alloca.m4 \
...

The obvious thing to do was to add two missing backslashes.

Then
configure; make distclean
gives the desired result (regex.c not deleted).
And I confirmed that no other file was deleted,
and that all the generated files are also part of
the distribution tarball.

So findutils is now distclean-clean, at least on Linux.

Could you file a (serious) bug against gnulib?

Martin

James Youngman wrote:
> Update of bugs #12064 (project findutils):
> 
>                   Status:                    None => Need Info              
>              Assigned to:                    None => jay                    
> 
>     _______________________________________________________
> 
> Follow-up Comment #1:
> 
> The regex.c file is a persistent problem.  See 
> 
> 
> 
> http://lists.gnu.org/archive/html/bug-gnulib/2004-10/msg00199.html
> 
> http://lists.gnu.org/archive/html/bug-gnulib/2004-12/msg00122.html
> 
> http://lists.gnu.org/archive/html/bug-gnulib/2005-01/msg00070.html
> 
> http://lists.gnu.org/archive/html/bug-gnulib/2005-01/msg00071.html
> 
> 
> 
> In summary, I have tried several ways of solving this problem, including the
> current strategy which is this:
> 
> 
> 
> ##
> 
> ## regex.c seems to get left out if I use automake-1.9 but not
> 
> ## if I use automake-1.7.   Hence dist-hook has to be able to
> 
> ## copy regex.c into the relevant (read-only) directory if it
> 
> ## is not already there, but needs to avoid doing so if the
> 
> ## file is already in place.   Ugh.
> 
> ##                             -- James Youngman <address@hidden>
> 
> ##
> 
> dist-hook: jy-regex-fix findutils-check-pofiles findutils-check-testfiles
> 
> 
> 
> jy-regex-fix:
> 
>         if test -f $(distdir)/gnulib/lib/regex.c ; then \
> 
>                 echo regex.c is already in place.  Great. ; \
> 
>         else \
> 
>                 echo Making $(distdir)/gnulib/lib writable ... ; \
> 
>                 chmod +w $(distdir)/gnulib/lib ; \
> 
>                 echo Copying $(srcdir)/gnulib/lib/regex.c to
> $(distdir)/gnulib/lib ; \
> 
>                 cp $(srcdir)/gnulib/lib/regex.c $(distdir)/gnulib/lib/regex.c
> ;
> 
> \
> 
>         fi
> 
> #       ls -ld $(srcdir)/gnulib/lib/regex.c $(distdir)/gnulib/lib
> 
> 
> 
> I have modified the toplevel Makefile.am to remove regex.c from
> CONFIG_CLEAN_FILES (see attached patch).  Please test this fix to make sure
> you're happy with it, either by applying the patch or by testing the CVS
> code, and let me know how you get on.
> 
> 
> 
> Goodnight,
> 
> James.
> 
> 
>     _______________________________________________________
> 
> Additional Item Attachment:
> 
> File name: findutils-4.2.18.regex-clean.patch Size:0 KB
> Proposed fix
> <http://savannah.gnu.org/bugs/download.php?item_id=12064&item_file_id=2230>
> 
>     _______________________________________________________
> 
> This item URL is:
> 
>   <http://savannah.gnu.org/bugs/?func=detailitem&item_id=12064>
> 
> _______________________________________________
>   Message sent via/by Savannah
>   http://savannah.gnu.org/
>