bug-findutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Patch] Locate: Move counting and limit-checking into visitors.


From: James Youngman
Subject: Re: [Patch] Locate: Move counting and limit-checking into visitors.
Date: Wed, 15 Jun 2005 21:33:16 +0100
User-agent: Mutt/1.3.28i

On Wed, Jun 15, 2005 at 10:10:55PM +0200, Bas van Gompel wrote:
> Hi,
> 
> Following patch moves limit-checking and counting into visitors.
> When neither is done, a visitor is added which will increment
> items_accepted once, then remove itself from the list.

I like visit_count() and visit_limit() but I'm not sure about
visit_found().  The latter is interesting but complicates the code -
what are the benefits that make it worthwhile to make the code more
complex?  I admit that the difference is small.

I'd prefer to adopt visit_count() and visit_limit() but not
visit_found().  However, if you can think of a strong agrument in
favour of visit_found() I could be convinced.  

James.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]