findutils-4.3.8: link-time failures on several platforms

[Nelson H. F. Beebe]

Builds of findutils-4.3.8 failed on several platforms because of
a missing (and nonstandard) symbol at link time:

NetBSD 1.6 IA-32 with gcc,
Solaris 8 SPARC,
Solaris 10 IA-32,
Solaris 10 SPARC,
SGI IRIX 6.5 with gcc:
        Unresolved text symbol "strcasestr" -- 1st referenced by locate.o.

Although the builds completed and validation test passed on all of my
GNU/Linux systems (Alpha, PowerPC, IA-32, IA-64, AMD64, SPARC), there
are a few other problems on other systems:

------------------------------------------------------------------------

On SGI IRIX 6.5 with c89:

c89 -DHAVE_CONFIG_H -I. -I.. -I../lib -I../gnulib/lib -I../gnulib/lib -I../intl 
\
        -DLOCATE_DB=\"/usr/local/var/locatedb\" 
-DLOCALEDIR=\"/usr/local/share/locale\" \
        -I/usr/local/include  -I/usr/local/include -c locate.c
cc-1552 c89: WARNING File = locate.c, Line = 571
  The variable "s" is set but never used.

    register char *s;
                   ^

cc-1241 c89: ERROR File = locate.c, Line = 1194
  A declaration cannot appear after an executable statement in a block.

              int more_read = fread (procdata.original_filename + nread, 1,
              ^

1 error detected in the compilation of "locate.c".

------------------------------------------------------------------------

On FreeBSD 5.0 and 6.1:

gcc  -I/usr/local/include  -Wl,-rpath,/usr/local/lib -o test-canonicalize-lgpl \
        test-canonicalize-lgpl.o ../gnulib/lib/libgnulib.a
../gnulib/lib/libgnulib.a(xalloc-die.o): In function `xalloc_die':
xalloc-die.o(.text+0xf): undefined reference to `libintl_gettext'
make[4]: Leaving directory `/local/build/gcc/findutils-4.3.8/tests'

The top-level Makefile has

LIBINTL = /usr/local/lib/libintl.so -L/usr/local/lib /usr/local/lib/libiconv.so 
-Wl,-rpath -Wl,/usr/local/lib

but that is apparently not propagated to the test subdirectory.

------------------------------------------------------------------------

On Mac OS X Intel with 64-bit compilation:

cc -DHAVE_CONFIG_H -I. -I../..  -I../../intl   -m64 -MT c-strstr.o -MD -MP -MF \
        .deps/c-strstr.Tpo -c -o c-strstr.o c-strstr.c
In file included from c-strstr.c:26:
./string.h:57: error: parse error before '__dest'

------------------------------------------------------------------------

On DEC Alpha OSF/1 with native cc:

cc -std -DHAVE_CONFIG_H -I. -I.. -I../gnulib/lib -I../lib -I../gnulib/lib 
-I../intl \
        -DLOCALEDIR=\"/usr/local/share/locale\"  -I/usr/local/include  -ieee \
        -I/usr/local/include -c tree.c
cc: Info: ../lib/buildcmd.h, line 107: Trailing comma found in enumerator list. 
(trailcomma)
  };
--^
cc: Info: defs.h, line 213: Trailing comma found in enumerator list. 
(trailcomma)
  };
--^
cc: Error: tree.c, line 980: In this statement, "pl1->fn" and "pl2->fn" cannot 
be compared with a relational operator. (norelational)
      assert(pl1->fn <= pl2->fn);
------^
cc: Error: tree.c, line 995: In this statement, "pc1->fn" and "pc2->fn" cannot 
be compared with a relational operator. (norelational)
  else if (pc1->fn > pc2->fn)
-----------^
make[3]: *** [tree.o] Error 1

------------------------------------------------------------------------

On Solaris 7 SPARC with gcc:

gcc -DHAVE_CONFIG_H -I. -I.. -I../gnulib/lib -I../lib -I../gnulib/lib -I../intl 
\
        -DLOCALEDIR=\"/usr/local/share/locale\"  -I/usr/local/include  -g -O2 
-c fstype.c
In file included from fstype.c:58:
defs.h:78: warning: `struct stat' declared inside parameter list
defs.h:78: warning: its scope is only this definition or declaration, which is 
probably not what you want.
defs.h:79: warning: `struct stat' declared inside parameter list
defs.h:80: warning: `struct stat' declared inside parameter list
defs.h:81: warning: `struct stat' declared inside parameter list
defs.h:83: warning: `struct stat' declared inside parameter list
defs.h:84: warning: `struct stat' declared inside parameter list
defs.h:98: warning: `struct stat' declared inside parameter list
defs.h:360: warning: `struct stat' declared inside parameter list
defs.h:401: warning: `struct stat' declared inside parameter list
defs.h:503: warning: `struct stat' declared inside parameter list
defs.h:510: warning: `struct stat' declared inside parameter list
defs.h:512: warning: `struct stat' declared inside parameter list
defs.h:579: warning: `struct stat' declared inside parameter list
fstype.c:85: warning: `struct stat' declared inside parameter list
fstype.c:161: warning: `struct stat' declared inside parameter list
fstype.c:162: conflicting types for `filesystem_type'
defs.h:360: previous declaration of `filesystem_type'
fstype.c: In function `filesystem_type':
fstype.c:168: dereferencing pointer to incomplete type
fstype.c:172: dereferencing pointer to incomplete type
fstype.c:173: warning: passing arg 1 of `filesystem_type_uncached' from 
incompatible pointer type
fstype.c: In function `set_fstype_devno':
fstype.c:180: storage size of `stbuf' isn't known
fstype.c: At top level:
fstype.c:221: warning: `struct stat' declared inside parameter list
fstype.c:222: conflicting types for `filesystem_type_uncached'
fstype.c:85: previous declaration of `filesystem_type_uncached'
fstype.c: In function `filesystem_type_uncached':

------------------------------------------------------------------------

On Solaris 7 SPARC with native cc:

cc -DHAVE_CONFIG_H -I. -I.. -I../lib -I../gnulib/lib -I../gnulib/lib \
        -I../intl -DLOCATE_DB=\"/usr/local/var/locatedb\" \
        -DLOCALEDIR=\"/usr/local/share/locale\"  -I/usr/local/include \
        -I/usr/local/include -c locate.c
"locate.c", line 1194: syntax error before or at: int
"locate.c", line 1196: undefined symbol: more_read
"locate.c", line 1402: cannot recover from previous errors
cc: acomp failed for locate.c

-------------------------------------------------------------------------------
- Nelson H. F. Beebe                    Tel: +1 801 581 5254                  -
- University of Utah                    FAX: +1 801 581 4148                  -
- Department of Mathematics, 110 LCB    Internet e-mail: address@hidden  -
- 155 S 1400 E RM 233                       address@hidden  address@hidden -
- Salt Lake City, UT 84112-0090, USA    URL: http://www.math.utah.edu/~beebe/ -
-------------------------------------------------------------------------------