[bug #48314] find -type f matches symlinks in armel armhf and mipsel

[Andreas Metzler]

Follow-up Comment #1, bug #48314 (project findutils):

Hello,

this is https://bugs.debian.org/827724 originally submitted by Maximiliano
Curia:
--------------------------
The new version of find has a weird behaviour, at least in the arches: armhf
armel and mipsel.
As simple test:

dir=$(mktemp -d)
cd $dir
ln -s a b
find -type f

Shows ./b while it shouldn't.

Interestingly:
$ find -type l
find: Duplicate file type 'l' in the argument list to -type

Both examples work fine in amd64.

I haven't followed the code thoroughly, but it seems that the type is using a

float to hold a bit mask, maybe this is not so well behaved in all arches.

[...]
With the addition of multiple types in one -type option, the args union of the

predicate struct has grown and the new space is not being initialized.
(The initialization of args is done as a args.str = NULL, but args.types is a

bool types[FTYPE_COUNT]; with count being 8, that's 32 bytes vs 4 that are 
currently initialized in a 32 bits arch.

Replacing the xmalloc invocation by a xzalloc one "fixes" the issue as it 
initializes all of the predicate components.

I'm attaching a patch that does this.
-----------------------------------
This is against GIT head after 6c37ce48a1eb3d1f21a1848cc9c40f2cdb191e88.

(file #37569)
    _______________________________________________________

Additional Item Attachment:

File name: replace_xmalloc_with_xzalloc.diff Size:0 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?48314>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/