Re: [bug-gawk] make check: 2 TESTS FAILED

[Aharon Robbins]

Hi.

> Date: Fri, 18 Oct 2013 11:54:39 +0200
> From: Hermann Peifer <address@hidden>
> To: address@hidden
> Subject: [bug-gawk] make check: 2 TESTS FAILED
>
> Hi,
>
> Below 2 issues after running make check. I am using Mac OS X Lion 10.7.5
>
> Regards, Hermann
>
>
> $ git status
> # On branch master
> nothing to commit, working directory clean
>
> $ ./bootstrap.sh && ./configure && make && make check
> ...
> pipeio3
> ./pipeio3.ok _pipeio3 differ: byte 43, line 3
> make[1]: [pipeio3] Error 1 (ignored)
> ...
> exit
> ./exit.ok _exit differ: byte 5, line 3
> make[1]: [exit] Error 1 (ignored)
> ...
> 2 TESTS FAILED
>
>
> $ diff test/pipeio3.ok test/_pipeio3
> 3c3
> < sh: 1: cart: not found
> ---
>  > sh: cart: command not found

This is not a real problem.

> $ diff test/exit.ok test/_exit
> 2a3
>  > gawk: warning: error writing standard output (Broken pipe)
> 11a13
>  > gawk: warning: error writing standard output (Broken pipe)

> Just to add that when running test/exit.sh repeatedly, the warning 
> message occurs either once, twice or not at all, see below.

This is more serious. I also see that it sometimes does different
things.

Below is a patch for both problems. Please let me know if it works
for you and I'll check it in.

Thanks

Arnold
---------------------------
diff --git a/test/Makefile.am b/test/Makefile.am
index abb3fb9..82d34a5 100644
--- a/test/Makefile.am
+++ b/test/Makefile.am
@@ -1882,6 +1882,12 @@ backsmalls1:
        AWKPATH="$(srcdir)" $(AWK) -f address@hidden "$(srcdir)"/address@hidden 
>_$@ 2>&1 || echo EXIT CODE: $$? >>_$@
        @-$(CMP) "$(srcdir)"/address@hidden _$@ && rm -f _$@
 
+pipeio3:
+       @echo $@
+       @AWKPATH="$(srcdir)" $(AWK) -f address@hidden  >_$@ 2>&1 || echo EXIT 
CODE: $$? >>_$@
+       @sed 's/cart: .*not found/cart: not found/' < _$@ >_x$@ ; mv _x$@ _$@
+       @-$(CMP) "$(srcdir)"/address@hidden _$@ && rm -f _$@
+
 # Targets generated for other tests:
 include Maketests
 
diff --git a/test/Makefile.in b/test/Makefile.in
index 9676494..448ec92 100644
--- a/test/Makefile.in
+++ b/test/Makefile.in
@@ -2275,6 +2275,12 @@ backsmalls1:
        @[ -z "$$GAWKLOCALE" ] && GAWKLOCALE=en_US.UTF-8; \
        AWKPATH="$(srcdir)" $(AWK) -f address@hidden "$(srcdir)"/address@hidden 
>_$@ 2>&1 || echo EXIT CODE: $$? >>_$@
        @-$(CMP) "$(srcdir)"/address@hidden _$@ && rm -f _$@
+
+pipeio3:
+       @echo $@
+       @AWKPATH="$(srcdir)" $(AWK) -f address@hidden  >_$@ 2>&1 || echo EXIT 
CODE: $$? >>_$@
+       @sed 's/cart: .*not found/cart: not found/' < _$@ >_x$@ ; mv _x$@ _$@
+       @-$(CMP) "$(srcdir)"/address@hidden _$@ && rm -f _$@
 Gt-dummy:
 # file Maketests, generated from Makefile.am by the Gentests program
 addcomma:
@@ -3184,11 +3190,6 @@ getlnhd:
        @AWKPATH="$(srcdir)" $(AWK) -f address@hidden  >_$@ 2>&1 || echo EXIT 
CODE: $$? >>_$@
        @-$(CMP) "$(srcdir)"/address@hidden _$@ && rm -f _$@
 
-pipeio3:
-       @echo $@
-       @AWKPATH="$(srcdir)" $(AWK) -f address@hidden  >_$@ 2>&1 || echo EXIT 
CODE: $$? >>_$@
-       @-$(CMP) "$(srcdir)"/address@hidden _$@ && rm -f _$@
-
 aadelete1:
        @echo $@
        @AWKPATH="$(srcdir)" $(AWK) -f address@hidden  >_$@ 2>&1 || echo EXIT 
CODE: $$? >>_$@
diff --git a/test/Maketests b/test/Maketests
index 29f9a17..df272ce 100644
--- a/test/Maketests
+++ b/test/Maketests
@@ -907,11 +907,6 @@ getlnhd:
        @AWKPATH="$(srcdir)" $(AWK) -f address@hidden  >_$@ 2>&1 || echo EXIT 
CODE: $$? >>_$@
        @-$(CMP) "$(srcdir)"/address@hidden _$@ && rm -f _$@
 
-pipeio3:
-       @echo $@
-       @AWKPATH="$(srcdir)" $(AWK) -f address@hidden  >_$@ 2>&1 || echo EXIT 
CODE: $$? >>_$@
-       @-$(CMP) "$(srcdir)"/address@hidden _$@ && rm -f _$@
-
 aadelete1:
        @echo $@
        @AWKPATH="$(srcdir)" $(AWK) -f address@hidden  >_$@ 2>&1 || echo EXIT 
CODE: $$? >>_$@
diff --git a/test/exit.sh b/test/exit.sh
index 9510dcd..c3d607f 100755
--- a/test/exit.sh
+++ b/test/exit.sh
@@ -8,26 +8,30 @@ then
        exit 1
 fi
 
+INPUT=/tmp/gawktestexit$$.in
+trap 'rm $INPUT' 0 HUP INT QUIT TERM
+
 # Use awk to print the string instead of echo or printf.
+$AWK 'BEGIN { print "a\nb" }' > $INPUT
 
 x='BEGIN{print 1; exit; print 2}; NR>1{print}; END{print 3; exit; print 4}'
-$AWK 'BEGIN { print "a\nb" }' | $AWK "$x"
+$AWK "$x" < $INPUT
 echo "-- 1"
 
 x='function f(){ exit}; END{print NR;f();print NR}'
-$AWK 'BEGIN { print "a\nb" }' | $AWK "$x"
+$AWK "$x" < $INPUT
 echo "-- 2"
 
 x='function f(){ exit}; NR>1 {f()}; END{print NR; f();print NR}'
-$AWK 'BEGIN { print "a\nb" }' | $AWK "$x"
+$AWK "$x" < $INPUT
 echo "-- 3"
 
 x='function f(){ exit}; NR>1{ f()}; END{print NR;print NR}'
-$AWK 'BEGIN { print "a\nb" }' | $AWK "$x"
+$AWK "$x" < $INPUT
 echo "-- 4"
 
 x='function f(){ exit}; BEGINFILE {f()}; NR>1{ f()}; END{print NR}'
-$AWK 'BEGIN { print "a\nb" }' | $AWK "$x"
+$AWK "$x" < $INPUT
 echo "-- 5"
 
 y='function strip(f) { sub(/.*\//, "", f); return f };'