Re: [bug-gawk] [PATCH] extension: Add $(DESTDIR) prefix to remaining pkgextensiondir instances

[Aharon Robbins]

Hi.

This got buried in my inbox.  I have just applied it and will push it
out shortly.

Thanks,

Arnold

> From: Paul Gortmaker <address@hidden>
> To: <address@hidden>
> CC: <address@hidden>, Paul Gortmaker <address@hidden>
> Subject: [PATCH] extension: Add $(DESTDIR) prefix to remaining 
> pkgextensiondir instances
> Date: Fri, 13 Jun 2014 13:58:48 -0400
>
> Commit 976f73ab03569bb836aa5c949be1c1cc973b2d2e ["Use $(DESTDIR) in
> extension/Makefile.am when removing .la files."] fixed an issue
> that manifested itself as follows when cross compiling:
>
> make[4]: Entering directory 'gawk/4.1.1-r0/build/extension'
> for i in filefuncs.la fnmatch.la fork.la inplace.la ordchr.la readdir.la 
> readfi
> le.la revoutput.la revtwoway.la rwarray.la testext.la time.la ; do \
>         rm -f /usr/lib/gawk/$i ; \
> done
> rm: cannot remove '/usr/lib/gawk/filefuncs.la': Permission denied
> rm: cannot remove '/usr/lib/gawk/fnmatch.la': Permission denied
> rm: cannot remove '/usr/lib/gawk/fork.la': Permission denied
> rm: cannot remove '/usr/lib/gawk/inplace.la': Permission denied
> rm: cannot remove '/usr/lib/gawk/ordchr.la': Permission denied
> rm: cannot remove '/usr/lib/gawk/readdir.la': Permission denied
> rm: cannot remove '/usr/lib/gawk/readfile.la': Permission denied
> rm: cannot remove '/usr/lib/gawk/revoutput.la': Permission denied
> rm: cannot remove '/usr/lib/gawk/revtwoway.la': Permission denied
> rm: cannot remove '/usr/lib/gawk/rwarray.la': Permission denied
> rm: cannot remove '/usr/lib/gawk/testext.la': Permission denied
> rm: cannot remove '/usr/lib/gawk/time.la': Permission denied
> Makefile:1235: recipe for target 'install-data-hook' failed
>
> The problem only manifests itself on hosts where the above files
> are already present; for if they are absent then the rm -f does
> not fail with -EPERM.  The fix in 976f73ab0356 ensured that DESTDIR
> was used for the prefix so that it didn't try to delete host files.
>
> However there still remains less used instances of where it is used
> w/o $(DESTDIR) that may still cause similar breakage in the future.
> Here we apply the same change to them.