Re: [bug-gawk] Mark strings as translatable in debug.c

[arnold]

Good point Eli. I will rework the code to use two messages.
I knew this, but needed the reminder.

Thanks!

Arnold

Eli Zaretskii <address@hidden> wrote:

> > Date: Thu, 26 Jan 2017 11:53:31 -0200
> > From: Rafael Fontenelle <address@hidden>
> > 
> > Mark "abnormally" and "normally" words as translatable in order to make
> > possible to a achieve a completely translated phrase with
> > "Program exited %s with exit value".
> > 
> > diff --git a/debug.c b/debug.c
> > index a2055301..dfd86723 100644
> > --- a/debug.c
> > +++ b/debug.c
> > @@ -2963,8 +2963,8 @@ do_run(CMDARG *arg ATTRIBUTE_UNUSED, int cmd 
> > ATTRIBUTE_UNUSED)
> >     fatal_tag_valid = false;
> >     prog_running = false;
> >     fprintf(out_fp, _("Program exited %s with exit value: %d\n"),
> > -                   (! exiting && exit_val != EXIT_SUCCESS) ? "abnormally"
> > -                                                           : "normally",
> > +                   (! exiting && exit_val != EXIT_SUCCESS) ? 
> > _("abnormally")
> > +                                                           : _("normally"),
> >                     exit_val);
>
> Moreover, breaking sentences into separate parts based on English
> grammar makes translations harder and their results of worse quality.
> It is better to have two complete sentences
>
>   "Program exited normally with exit value: %d\n"
>
> and
>
>   "Program exited abnormally with exit value: %d\n"
>
> even though it wastes some storage, because in languages other than
> English the full sentence may not easily be broken into those 2 parts.