Re: [bug-gawk] macOS: mpfrsqrt check fails on gawk-4.2-stable and master branches

[Andrew J. Schorr]

On Fri, Feb 09, 2018 at 08:47:25PM +0100, Hermann Peifer wrote:
> Indeed. I forgot a few lines from the make check output. Sorry, Hermann
> 
> ! 11111111111111109867334288901275613641560219569226843684864
> make[2]: Leaving directory '/Users/peifer/local/src/gawk/test'
> make[1]: *** [Makefile:1819: check] Error 1
> make[1]: Leaving directory '/Users/peifer/local/src/gawk/test'
> make: *** [Makefile:725: check-recursive] Error 1

OK, thanks.

Can anyone come up with a better warning message? This seems a bit clunky:

warning: intdiv: MPFR arguments converted to IEEE because this extension was 
not compiled with MPFR support; loss of precision may occur

Should we avoid saying "MPFR" in favor of "arbitrary precision"? Maybe:

warning: intdiv: arbitrary-precision arguments converted to standard precision 
because this extension was not compiled with MPFR support; loss of precision 
may occur

But this is very wordy. There must be a more succinct way to say this...

Also, I think it should be OK to replace

                if (nv.num_type != AWK_NUMBER_TYPE_DOUBLE || dv.num_type != 
AWK_NUMBER_TYPE_DOUBLE) {

with a single check:

                if (nv.num_type != AWK_NUMBER_TYPE_DOUBLE) {

Arnold -- do you agree?

Regards,
Andy