Re: [bug-gettext] gettext maintenance

[Daiki Ueno]

Bruno Haible <address@hidden> writes:

> FAIL: test-u8-possible-linebreaks
> FAIL: test-ulc-width-linebreaks
> FAIL: test-u8-mbtouc
> FAIL: test-u8-mbtouc-unsafe
> FAIL: uniwidth/test-uc_width2.sh
>
> These failures are consequences of changes in libunistring behaviour.
> What happens is that gettext embeds the test suite from the newest
> (unreleased) libunistring, but the LDFLAGS make it link to the
> installed libunistring. Any change in behaviour thus comes out as a
> test failure.

Thanks for the hint.  I'm thinking of skipping those tests for now, like
the attached patch.  Maybe there is a better way, suggestions would be
appreciated.

>From 37bd6b334e0c48c2d7d48578b7969c4f7872028d Mon Sep 17 00:00:00 2001
From: Daiki Ueno <address@hidden>
Date: Fri, 7 Dec 2012 19:00:45 +0900
Subject: [PATCH] Ignore tests which fail with released libunistring.

---
 ChangeLog  |  5 +++++
 autogen.sh | 11 ++++++++++-
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index f38e973..980c390 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2012-12-07  Daiki Ueno  <address@hidden>
+
+       * autogen.sh: Ignore tests which fail with the released libunistring.
+       (GNULIB_MODULES_TOOLS_IGNORED): New variable.
+
 2012-04-29  Bruno Haible  <address@hidden>
 
        Allow use of autoconf-2.69 and automake-1.12.
diff --git a/autogen.sh b/autogen.sh
index 904254f..c073d8c 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -251,8 +251,17 @@ if ! $skip_gnulib; then
       javaexec-script
       stdint
     '
+    # Ignore tests known to be fail with the released libunistring.
+    GNULIB_MODULES_TOOLS_IGNORED='
+      hash-tests
+      unilbrk/u8-possible-linebreaks-tests
+      unilbrk/ulc-width-linebreaks-tests
+      unistr/u8-mbtouc-tests
+      unistr/u8-mbtouc-unsafe-tests
+      uniwidth/width-tests
+    '
     $GNULIB_TOOL --dir=gettext-tools --lib=libgettextlib 
--source-base=gnulib-lib --m4-base=gnulib-m4 --tests-base=gnulib-tests 
--makefile-name=Makefile.gnulib --libtool --with-tests --local-dir=gnulib-local 
--local-symlink \
-      --import --avoid=hash-tests $GNULIB_MODULES_TOOLS_FOR_SRC 
$GNULIB_MODULES_TOOLS_FOR_SRC_COMMON_DEPENDENCIES $GNULIB_MODULES_TOOLS_OTHER
+      --import `for m in $GNULIB_MODULES_TOOLS_IGNORED; do echo --avoid=$m; 
done` $GNULIB_MODULES_TOOLS_FOR_SRC 
$GNULIB_MODULES_TOOLS_FOR_SRC_COMMON_DEPENDENCIES $GNULIB_MODULES_TOOLS_OTHER
     # In gettext-tools/libgrep:
     GNULIB_MODULES_TOOLS_FOR_LIBGREP='
       mbrlen
-- 
1.7.11.7

Regards,
-- 
Daiki Ueno