Re: [bug-gettext] [PATCH] gettext-runtime/intl: Merge from glibc

[Daiki Ueno]

Will Newton <address@hidden> writes:

>> As a minor nitpicking, I'm not sure if we can join the intervals of
>> copyright years.  How about using update-copyright in Gnulib?
>
> The reason I did this is that matches the copyright in glibc, which
> has the practice of using the full range of years for most files
> including the intl ones.

I don't have strong opinion here, but:

> https://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html

This also contains:

"You can use a range (‘2008-2010’) instead of listing individual years
(‘2008, 2009, 2010’) if and only if: 1) every year in the range,
inclusive, really is a “copyrightable” year that would be listed
individually; and 2) you make an explicit statement in a README file
about this usage."

I guess we should at least have the statement in README, like glibc.

By the way:

>       Test HAVE_DECL_FGETS_UNLOCKED with #ifdef rather than #if.
>       Test HAVE_DECL_FEOF_UNLOCKED with #ifdef rather than #if.

> -#if defined _LIBC_REENTRANT || HAVE_DECL_FGETS_UNLOCKED
> +#if defined _LIBC_REENTRANT || defined HAVE_DECL_FGETS_UNLOCKED

This is no-no.  On some platforms (e.g. Mac OS X),
HAVE_DECL_FGETS_UNLOCKED will be defined as 0:

  $ grep 'define HAVE_DECL_FGETS' gettext-runtime/config.h
  #define HAVE_DECL_FGETS_UNLOCKED 0

What's the rationale behind this change?  According to C99 and C11, the
C preprocessor shall convert undefined identifiers to pp-number 0 before
evaluation.

Regards,
--
Daiki Ueno