Re: [bug-gettext] [PATCH] OS/2 patches

[KO Myung-Hun]

Hi/2.

Daiki Ueno wrote:
> KO Myung-Hun <address@hidden> writes:
> 
> Thanks for the patches.  Some comments below.
> 
>> [PATCH 1/8] moop: Replace CR as well as NL with a space
> 
> I'm not sure who adds CR here.  Can't we assume that all source files
> use NL line termination?  Or some other tools add CR on OS/2?  Also, I
> worry about the portability of '\r' as an argument of tr.
> 

sed. On OS/2, many utils such as sed, coreutils and sh use CR+LF as a
EOL marker instead of LF only.

I replaced '\r' with '\015' in according to John Cowan

>> [PATCH 2/8] test-lock: Do not include sched.h on kLIBC
>> [PATCH 3/8] build: Do not include os2compat.[ch]
>> [PATCH 4/8] gettext-runtime: Fix name resolution failures on kLIBC
> 
> Those seem to be OK.
> 
>> [PATCH 5/8] intl: Support UNIXROOT in BINDTEXTDOMAIN () on EMX
> 
> Doesn't this conflict with the UNIXROOT resolution in os2compat.c?
> 

I removed the dependencies on os2compat.[ch] from kLIBC code paths at
With [PATCH 3/8]. So this will not conflict with os2compat.c

Even if EMX is used, it will be no problem because this patch check the
condition strictly. That is, once os2compat.c resolved UNIXROOT, this
patch does not prepend UNIXROOT.

> Also, since it changes the calling convention of bindtextdomain(), which
> previously assumed that it is user's responsibility to resolve DIRNAME,
> doesn't it break existing programs?

No, it will not. Because this patch will prepend a drive to an absolute
path starting with '/' or '\'. And all unix utils following FHS as well
as gettext is installed on the drive.

> 
>> [PATCH 6/8] libasprintf: Build a shared library on OS/2
>> [PATCH 7/8] gettext-tools: Use a short name for DLLs on OS/2
> 
> Those look a bit ugly, but should be OK.
> 
>> [PATCH 8/8] xgettext, cldr-plurals: Fix linkage on OS/2
> 
> After merging the ITS branch (wip/ueno/its2), I plan to replace the
> libexpat dependencies with libxml2 (for tools) and a hand written XML
> parser (for libgettextpo, maybe ported from GLib's gmarkup.c).  So this
> shouldn't be necessary.

Then, @LTLIBEXPAT@ is removed from libgettextsrc, too ?

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr