Re: [bug-gettext] Failed Tests

[Daiki Ueno]

"Mulcihy, David D. (JSC-OD)[THE BOEING COMPANY]"
<address@hidden> writes:

Thanks for the report.

> 1)      Compile time issue with SunStudio 12.4 compiler. Apparently it is 
> more pendantic the gcc.
> The redeclared function is libintl_gettext_germanic_plural. Line 71 in 
> plural-exp.c has it as struct,
> Line 111 in plural-exp.h has it as const struct.

This is the same issue as:
https://savannah.gnu.org/support/?108743
where I suggested to use CFLAGS="-xc99=all,lib -Xc" as a work around.

However, it seems that the C compiler of SunStudio 12.4 actually
supports the needed C99 feature (struct/union initialiazers) by default.
Perhaps it might make sense to enable it like the attached patch.

> 2)      3 Failed tests 
> FAIL: test-mbrtowc3.sh
> FAIL: test-mbrtowc4.sh
> FAIL: test-mbsrtowcs4.sh

I suppose those are:
https://lists.gnu.org/archive/html/bug-gnulib/2014-11/msg00012.html
where the problem is caused by missing locale packages.

Regards,
-- 
Daiki Ueno

>From 8407ae13aa28a53dd29d14ab16220ef82e2437e0 Mon Sep 17 00:00:00 2001
From: Daiki Ueno <address@hidden>
Date: Tue, 24 May 2016 12:18:07 +0900
Subject: [PATCH] intl: Pacify SunStudio C compiler

* gettext-runtime/intl/plural-exp.c [__SUNPRO_C]: Use named struct/union
initializers.
---
 gettext-runtime/intl/plural-exp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gettext-runtime/intl/plural-exp.c 
b/gettext-runtime/intl/plural-exp.c
index 7f37e54..bfb228d 100644
--- a/gettext-runtime/intl/plural-exp.c
+++ b/gettext-runtime/intl/plural-exp.c
@@ -25,7 +25,8 @@
 
 #include "plural-exp.h"
 
-#if (defined __GNUC__ && !(defined __APPLE_CC_ && __APPLE_CC__ > 1) \
+#if ((defined __GNUC__ || defined __SUNPRO_C)                       \
+     && !(defined __APPLE_CC_ && __APPLE_CC__ > 1)                  \
      && !defined __cplusplus)                                       \
     || (defined __STDC_VERSION__ && __STDC_VERSION__ >= 199901L)
 
-- 
2.5.5