Re: [bug-gettext] Errors building with getttext-runtime/po/Makefile.in.in

[Ed]

Hi Bruno

Thanks for your help.

Running gettextize on freedroid's repo seems to not be compatible with
how it's currently set up (the current structure seems to date from
2009 - I'm not a contributor to this project, I was trying to help
out, so I don't know the full history). I get broken makefiles, and
the po structure it wants to create doesn't match the existing, even
after following all of its instructions.

I can't see any place in which top_builddir is exported in the current
set of makefile templates. Gnu Make's documentation admits no
instances in which the variable would be exported without a
declaration. top_srcdir is already set up for substitution in the
makefile. So I don't see how it can possibly work, regardless of what
tools I run, unless they export additional variables in some unclear
manner.

In any case, unfortunately I've spent as long looking at this now
(about a week of my free time) as I can without getting results. I'll
just patch the Makefile.in locally as I think it should be and move
on.

Thanks again for your help

Ed


On 2 August 2018 at 02:12, Bruno Haible <address@hidden> wrote:
> Hi,
>
>> gettext-runtime/po/Makefile.in.in uses the variable top_builddir, but
>> that variable is not directly set in the makefile, unlike (for
>> example) top_srcdir.
>>
>> This causes build errors for me building applications out-of-tree
>> (specifically, freedroid latest has this problem for me with autoconf
>> 2.69, automake 1.15.1 - the latest for Ubuntu 18.04).
>>
>> I think the fix is just to add
>>
>> top_builddir = @top_builddir@
>>
>> to the top of the file.
>
> Did you follow all recommendations that gettextize did output,
> when you ran gettextize?
>
> Also, the comment #5 of
> https://bugs.launchpad.net/ubuntu/+source/gettext/+bug/122343
> might help.
>
> Bruno
>