bug-global
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC] search functions which ignore case.


From: Yushi Oka
Subject: Re: [RFC] search functions which ignore case.
Date: Tue, 03 Apr 2012 23:01:22 +0900

Hi,

On Mon, 04 Jul 2011 15:06:33 +0900
"Shigio YAMAGUCHI" <address@hidden> wrote:

 〆 ̄ ̄ ̄ ̄ ̄ ̄ ̄ ̄ ̄ ̄ ̄ ̄ ̄ ̄ ̄ ̄ ̄ ̄ ̄ ̄ ̄ ̄ ̄
| Hi all,
| I would like to make search functions which ignore case available in gtags.el.
| 
| How about having each gtags-find-XXX command (gtags-find-tag, 
gtags-find-file,...)
| to refer variable 'case-fold-search'?
| Though it is a INCOMPATIBLE CHANGE, this is suitable for the long.
| Because this follows the convention of Emacs.
| 
| What do you think?

I think,
It is better to refer both variable 'case-fold-search' and defcustom.
Because I would like to ignore case in 'isearch', but not in global.

for example,

$ diff -ur gtags.el.3.4 gtags.el
--- gtags.el.3.4        2012-03-16 09:59:32.000000000 +0900
+++ gtags.el    2012-04-03 22:09:47.359375000 +0900
@@ -105,6 +105,11 @@
   :group 'gtags
   :type 'boolean)
 
+(defcustom gtags-folllows-case-fold-search nil
+  "*If non-nil, gtags follows 'case-fold-search' variable."
+  :group 'gtags
+  :type 'boolean)
+
 (defcustom gtags-disable-pushy-mouse-mapping nil
   "*If non-nil, mouse key mapping is disabled."
   :group 'gtags
@@ -384,7 +389,7 @@
                       (t                  "-c")))
         (complete-list (make-vector 63 0))
         (prev-buffer (current-buffer)))
-    (if case-fold-search
+    (if (and gtags-folllows-case-fold-search case-fold-search)
         (setq option (concat option "i")))
     ; build completion list
     (set-buffer (generate-new-buffer "*Completions*"))
@@ -659,7 +664,7 @@
     (setq flag-char (string-to-char flag))
     ; Use always ctags-x format.
     (setq option "-x")
-    (if case-fold-search
+    (if (and gtags-folllows-case-fold-search case-fold-search)
         (setq option (concat option "i")))
     (if (char-equal flag-char ?C)
         (setq context (concat "--from-here=" (number-to-string 
(gtags-current-lineno)) ":" (gtags-buffer-file-name)))

-- 
Yushi Oka <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]