Re: bug in gtags.vim

[Shigio YAMAGUCHI]

Thank you. I have commited it.

My insufficient code seems to be still left.
I will check similar places again.

On Tue, 25 Jun 2013 20:11:24 +1000
Jason Hood <address@hidden> wrote:

> On 21/06/2013 13:44, Shigio YAMAGUCHI wrote:
> > It seems that I need a Windows environment.
> > It will make it to fix these problems.
> 
> Just received an email about problems with idutils - another
> single-quote versus double-quote issue (I *really* gotta do
> more testing...).
> 
> --- global/global~.c  2013-02-28 21:21:06.000000000 +1000
> +++ global/global.c   2013-06-25 19:13:19.705872000 +1000
> @@ -929,7 +929,7 @@
>       if (!lid)
>               die("lid(idutils) not found.");
>       strbuf_puts(sb, lid);
> -     strbuf_sprintf(sb, " --file='%s/ID'", dbpath);
> +     strbuf_sprintf(sb, " --file=%s/ID", quote_shell(dbpath));
>       strbuf_puts(sb, " --key=token");
>       if (iflag)
>               strbuf_puts(sb, " --ignore-case");
> @@ -1090,7 +1090,7 @@
>        * Invoke lid with the --result=grep option to generate grep format.
>        */
>       strbuf_puts(ib, lid);
> -     strbuf_sprintf(ib, " --file='%s/ID'", dbpath);
> +     strbuf_sprintf(ib, " --file=%s/ID", quote_shell(dbpath));
>       strbuf_puts(ib, " --separator=newline");
>       if (format == FORMAT_PATH)
>               strbuf_puts(ib, " --result=filenames --key=none");
> --- gtags/gtags~.c    2013-02-28 21:21:06.000000000 +1000
> +++ gtags/gtags.c     2013-06-25 19:13:22.061476200 +1000
> @@ -498,7 +498,7 @@
>               strbuf_puts(sb, "mkid");
>               if (vflag)
>                       strbuf_puts(sb, " -v");
> -             strbuf_sprintf(sb, " --file='%s/ID'", dbpath);
> +             strbuf_sprintf(sb, " --file=%s/ID", quote_shell(dbpath));
>               if (vflag) {
>  #ifdef __DJGPP__
>                       if (is_unixy()) /* test for 4DOS as well? */
> 
> -- 
> Jason.


-- 
Shigio YAMAGUCHI <address@hidden>
PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3