Re: Segmentation fault w/ Gnats 4.0.1

[Chad Walstrom]

Pankaj Garg wrote:
> Haven't had a chance to explore further, but it seems that the problem
> was happening when there was only an '\n' for the third field
> (address) in the responsible file. Seems like the isspace logic is
> somehow getting messed up. Before I dig deeper, just wanted to see if
> someone else has experienced anything like this.

It's a reasonable hack.  I can't see a situation where the current
pointer would be less than addrStart, so comparing equality is probably
good enough, but I agree that the comparison is needed.

When a single character string (i.e. '\0') is passed to xstrndup (found
in misc.c) with a length specification of zero (i.e. addr - addrStart ==
0), you get Bad Things.  xstrndup() should probably validate the length
parameter to protect against this type of error.  It passes the same
length parameter to memcpy().  This is where gnatsd is probably
crashing.

Good catch.  Thanks!

-- 
Chad Walstrom <chewie@wookimus.net>           http://www.wookimus.net/
           assert(expired(knowledge)); /* core dump */

signature.asc
Description: Digital signature