possible mistake in ScoreP

[Bernard Helmstetter]

Hi everybody,

There might be a mistake in the function ScoreP in eval.c:

  /* Pawn on f6/c6 with Queen against castled king is very strong */
  c = board.b[side][pawn];
  sq = board.king[xside];
  if (side == white && board.b[side][queen] &&
   (BitPosArray[C6] | BitPosArray[F6]) & c)
  {
     if (c & BitPosArray[F6] && sq > H6 && distance[sq][G7]==1)
        s += PAWNNEARKING;
     if (c & BitPosArray[C6] && sq > H6 && distance[sq][B7]==1)
        s += PAWNNEARKING;
  }
  else if (side == black && board.b[side][queen] &&
   (BitPosArray[C3] | BitPosArray[F3]) & c)
  {
     if (c & BitPosArray[F3] && sq < A3 && distance[sq][G2]==1)
        s += PAWNNEARKING;
     if (c & BitPosArray[C3] && sq < A3 && distance[sq][B2]==1)
        s += PAWNNEARKING;
  }

In my opinion, the test about the location of the king (sq) should 
depend on the location of the pawn.

Bernard Helmstetter