[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: diff-switches defined in two places
|
From: |
Andre Spiegel |
|
Subject: |
Re: diff-switches defined in two places |
|
Date: |
22 Oct 2001 01:42:30 +0200 |
|
User-agent: |
Gnus/5.09 (Gnus v5.9.0) Emacs/21.0.106 |
> Simon Josefsson <jas@extundo.com> writes:
>
> > I don't understand why `diff-switches' is defined in vc.el, the
> > variable is autoloaded from diff.el anyway. The patch below removes
> > the definition and changes the default value of vc-diff-switches as
> > well. It seems it didn't have a :version tag though..
The first part looks okay, but the second part is definitely wrong:
vc-diff-switches is not supposed to be initialized with diff-switches.
When VC does a diff, it combines diff-switches, vc-diff-switches, and
vc-BACKEND-diff-switches to get the actual switches for the command.
So, vc-diff-switches is meant to contain any switches that are
specific to version control, but not specific to any of the backends.
I have removed the duplicate definition in the sources, but kept
vc-diff-switches as it was. Thanks for pointing this out!