Re: 21.1: mh-e folder mode displayed incorrectly

[Peter S Galbraith]

Gerd Moellmann wrote:

> Kevin Layer <layer@franz.com> writes:
> 
> > I don't know if this is a bug in mh-utils.el or the function recenter,
> > but if I change the following
> > 
> > (defun mh-recenter (arg)
> >   ;; Like recenter but with two improvements: nil arg means recenter,
> >   ;; and only does anything if the current buffer is in the selected
> >   ;; window.  (Commands like save-some-buffers can make this false.)
> >   (if (eq (get-buffer-window (current-buffer))
> >       (selected-window))
> >       (recenter (if arg arg '(t)))))
> > 
> > to
> > 
> > (defun mh-recenter (arg)
> >   ;; Like recenter but with two improvements: nil arg means recenter,
> >   ;; and only does anything if the current buffer is in the selected
> >   ;; window.  (Commands like save-some-buffers can make this false.)
> >   (if (eq (get-buffer-window (current-buffer))
> >       (selected-window))
> >       (recenter (if arg arg t))))
> > 
> > I get the old and correct behavior.
> > 
> > It appears that recenter isn't behaving the same, and I don't if this
> > was intentional or not.
> 
> Thanks for the report.  I think recenter is okay, but mh-e should
> have used t instead of `(t)'.  I've fixed that.

I disagree.  :-)

Try

 M-: (recenter)

and you'll see the same unwanted effect

If you set mh-summary-height to some larger value to get more
than 3 lines for the MH-folder buffer, e.g.

 (setq mh-summary-height 10)

you'll see that (recenter t) doesn't work.  It just centers on
the second line, instead of in the middle:

So it's Emacs' builtin 'recenter' that has changed.

Peter