bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] 21.3 filecache.el - Added Cygwin support


From: Jari Aalto+mail.linux
Subject: Re: [patch] 21.3 filecache.el - Added Cygwin support
Date: Sun, 25 Jan 2004 13:52:12 +0200
User-agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/20.7 (windows-nt) (i386-*-nt5.0.2195)

* Sat 2004-01-24 Eli Zaretskii <eliz@elta.co.il> gnu.emacs.bug
* 
<http://groups.google.com/groups?oi=djq&as_umsgid=%3Cmailman.1267.1074941456.928.bug-gnu-emacs@gnu.org>
| > From: jari.aalto@poboxes.com (Jari Aalto+mail.emacs)
| > Date: Sat, 24 Jan 2004 11:25:08 +0200
| > 
| > 2004-01-24 Sat  Jari Aalto  <jari.aalto@poboxes.com>
| > 
| >         * filecache.el
| >         (file-cache-find-unix-p): New function. Detect Cygwin.
| >         (file-cache-add-directory-using-find): Added Cygwin support
| >         (file-cache-find-command-unix-flag): New user variable.
| 
| Thanks.
| 
| One thing I don't understand about these changes: why do we need all
| those ugly system-dependent tests?  Why not test if `find' is
| installed on all supported platforms regardless?

The "find" from Windows is different from the Cygwin (Unix) "find", so
this distinctions must be examined.
 
| But if you do want to avoid the test on Unix, let's do it on all
| non-Unix systems, not only on windows-nt.

Right. Anything else missing?
Jari




2004-01-25 Sun  Jari Aalto  <jari.aalto@poboxes.com>

        * filecache.el (file-cache-find-unix-p): Added
        check for `ms-dos' as well.


Index: filecache.el
===================================================================
RCS file: 
/cygdrive/h/data/version-control/cvsroot/emacs/gnu-emacs/lisp213/filecache.el,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -IId: -b -w -u -r1.3 -r1.4
--- filecache.el        24 Jan 2004 09:25:44 -0000      1.3
+++ filecache.el        25 Jan 2004 11:49:15 -0000      1.4
@@ -329,7 +329,9 @@

 (defun file-cache-find-unix-p ()
   "Check if `file-cache-find-command' is Unix type program."
-  (or (not (eq system-type 'windows-nt))  ;; Assume Unix system
+  (or (not (memq system-type              ;; Assume Unix system
+                 '(windows-nt
+                   'ms-dos)))
       (with-temp-buffer                   ;; Cygwin?
         (call-process file-cache-find-command
                       nil



-- 
http://tiny-tools.sourceforge.net/
Swatch @time   http://www.mir.com.my/iTime/itime.htm
               http://www.ryanthiessen.com/swatch/resources.htm
Use Licenses!  http://www.linuxjournal.com/article.php?sid=6225
Which Licence? http://www.linuxjournal.com/article.php?sid=4825
OSI Licences   http://www.opensource.org/licenses/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]