Re: accept-process-output incompatible change in CVS Emacs: patch included

[Per Cederqvist]

On 5/5/07, Kim F. Storm <no-spam@cua.dk> wrote:
> Per Cederqvist <ceder@ingate.com> writes:
>
> > This change in the upcoming Emacs 22 breaks some code:
> >
> >> 2006-03-22  Kim F. Storm  <storm@cua.dk>
> >>
> >>      * process.c (Faccept_process_output): Fix to comply with lisp
> >>      reference.  Change arg "timeout" to "seconds" and allow both
> >>      integer and float value.  Change arg "timeout-msec" to "millisec"
> >>      and interpret" as milliseconds rather than microseconds.  Fix doc
> >>      string accordingly.
>
> Please see:
>
> http://lists.gnu.org/archive/html/emacs-devel/2006-03/msg00937.html

rms has already installed my patch, so I guess Gnus will have to be
fixed.  I was not aware that XEmacs used milliseconds.  Maybe the
documentation should be updated to tell everybody to use floating
point instead, as the interpretation of the msec argument varies.

> > I enclose a patch that makes accept-process-output
> > backwards-compatible with Emacs 21.
> >
> > One application I'm running now runs very slowly, since its carefully
> > tuned timeoutes are multiplied by 1000.
>
> Well, other code believing the lisp ref, and was broken by the old
> behaviour.
>
> So just reverting the change is no good at this time.

If the millisecond interpretation is once again installed, please make
the code raise an overflow error if a value larger than 1000 is
supplied.  This way, code that relies on the old behaviour will not
silently be slow, but instead raise an error so that the problem is
found and can be fixed.

> What application is that?

A client to the LysKOM system, called lyskom-elisp-client.  Info about
the entire system is available from
http://www.lysator.liu.se/lyskom/index-en.html, and the client itself
can be found in ftp://ftp.lysator.liu.se/pub/lyskom/elisp-client/.

> >  If, for some reason, my patch is unacceptable, please
> > mention this as an incompatible change in the NEWS file.
>
> This is a good point.
>
> --
> Kim F. Storm  http://www.cua.dk

   /ceder