|
From: | Lennart Borgman (gmail) |
Subject: | Re: Bad value in file-coding-system-alist |
Date: | Mon, 09 Jul 2007 21:45:29 +0200 |
User-agent: | Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4) Gecko/20070604 Thunderbird/2.0.0.4 Mnenhy/0.7.5.666 |
Katsumi Yamaoka wrote:
Katsumi Yamaoka wrote:I guess the reason the `coding-system' widget doesn't check whether the value is a coding system is for the coding systems that are defined afterward, e.g., the ones to be autoloaded.Therefore, I modified the `coding-system' widget only for `file-coding-system-alist' so that it may not issue an error signal when the value is a function. Committed in both the Emacs trunk and the EMACS_22_BASE branch.Oops. The fix I committed was incorrect. I've fixed it again in the trunk and the EMACS_22_BASE branch. The following patch for the Emacs 22.1 release represents what I did:
Are you sure this is the right fix? Is not this a general problem with Custom?
*** cus-start.el~ Thu Apr 12 03:05:31 2007 --- cus-start.el Mon Jul 9 01:33:47 2007 *************** *** 122,129 **** :value (undecided . undecided) (coding-system :tag "Decoding") (coding-system :tag "Encoding")) ! (coding-system :tag "Single coding system" ! :value undecided) (function :value ignore)))) (selection-coding-system mule coding-system) ;; dired.c --- 122,132 ---- :value (undecided . undecided) (coding-system :tag "Decoding") (coding-system :tag "Encoding")) ! (coding-system ! :tag "Single coding system" ! :value undecided ! :match (lambda (widget value) ! (and value (not (functionp value))))) (function :value ignore)))) (selection-coding-system mule coding-system) ;; dired.c Regards,
[Prev in Thread] | Current Thread | [Next in Thread] |