bug#699: grep in eshell incorrect

[Glenn Morris]

Eli Zaretskii wrote:

>> If standard output is a terminal, the output is in columns (sorted
>> vertically) and control characters are output as question marks;
>> otherwise, the output is listed one per line and control characters
>>                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> Not with "ls -x".

Alrighty.

*** em-ls.el    7 Jun 2008 02:37:12 -0000       1.33
--- em-ls.el    13 Aug 2008 03:20:19 -0000
***************
*** 635,641 ****
    "Output a list of FILES.
  Each member of FILES is either a string or a cons cell of the form
  \(FILE .  ATTRS)."
!   (if (memq listing-style '(long-listing single-column))
        (eshell-for file files
        (if file
            (eshell-ls-file file size-width copy-fileinfo)))
--- 635,646 ----
    "Output a list of FILES.
  Each member of FILES is either a string or a cons cell of the form
  \(FILE .  ATTRS)."
!   ;; Mimic behavior of coreutils ls, which lists a single file per
!   ;; line when output is not a tty.  Unless -x was supplied.
!   ;; FIXME we should not be doing this if we are at the _end_ of a pipeline.
!   (if (or (and (not (eq listing-style 'by-lines))
!              eshell-in-pipeline-p)
!         (memq listing-style '(long-listing single-column)))
        (eshell-for file files
        (if file
            (eshell-ls-file file size-width copy-fileinfo)))