bug#698: marked as done (regexp problem in ldap.el)

[Emacs bug Tracking System]

Your message dated Sun, 24 Aug 2008 00:23:33 -0400
with message-id <87bpzjvy62.fsf@cyd.mit.edu>
and subject line Re: regexp problem in ldap.el
has caused the Emacs bug report #698,
regarding regexp problem in ldap.el
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
698: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=698
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: regexp problem in ldap.el
>
>
>
>
> Date: 
>
> Tue, 12 Aug 2008 13:04:40 +0900 (JST)
>
>
>
>
> According to the rfc4512, \w is not good to match against attribute type
> and options.  With the attached patch, options containing hyphens are
> successfully parsed.
>
> P.S.
>
> I submitted a bug report about regexp in ldap-search-internal last
> December, but now I understand that it was a mistake.
>
> ---- patch from here ----
> --- ldap.orig.el        2008-08-09 08:04:07.000000000 +0900
> +++ ldap.el     2008-08-09 22:37:05.000000000 +0900
> @@ -582,9 +582,9 @@
>                                                (end-of-line)
>                                                (point))))
>           (forward-line 1)
> -         (while (looking-at "^\\(\\w*\\)\\(;\\w*\\)?[=:\t ]+\\(&lt;[\t ]*file
> :\
> //\\)\\(.*\\)$")
> +         (while (looking-at "^\\([A-Za-z][-A-Za-z0-9]*\\|[0-9]+\\(\\.[0-9]+\\
> )\
> *\\)\\(;[-A-Za-z0-9]+\\)*[=:\t ]+\\(<[\t ]*file://\\)\\(.*\\)$")
>             (setq name (match-string 1)
> -                 value (match-string 4))
> +                 value (match-string 5))
>              ;; Need to handle <a href="file:///D:/...">file:///D:/...</a> as 
> g\
> enerated by OpenLDAP
>              ;; on DOS/Windows as local files.
>              (if (and (memq system-type '(windows-nt ms-dos))
> ---- patch ends here ----
>
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: regexp problem in ldap.el
>
>
>
>
> Date: 
>
> Sun, 24 Aug 2008 00:23:33 -0400
>
>
>
>
> User-agent: 
>
> Gnus/5.11 (Gnus v5.11) Emacs/22.2.90 (gnu/linux)
>
>
>
>
> gha03025@nifty.ne.jp (中川 誠) writes:
>
> > What I mean by garbage is backslash and LF at the end of lines.
> > Shouldn't it be like the following?
> >
> > --- from here ---
> > --- ldap.1.26.2.3.el  2008-08-24 06:40:45.000000000 +0900
> > +++ ldap.el   2008-08-24 06:46:27.000000000 +0900
> > @@ -584,9 +584,7 @@
> >                                              (end-of-line)
> >                                              (point))))
> >         (forward-line 1)
> > -          (while (looking-at "^\\([A-Za-z][-A-Za-z0-9]*\
> > -\\|[0-9]+\\(?:\\.[0-9]+\\)*\\)\\(;[-A-Za-z0-9]+\\)*[=:\t ]+\
> > -\\(<[\t ]*file://\\)\\(.*\\)$")
> > +          (while (looking-at 
> > "^\\([A-Za-z][-A-Za-z0-9]*\\|[0-9]+\\(?:\\.[0-9]+\\)*\\)\\(;[-A-Za-z0-9]+\\)*[=:\t
> >  ]+\\(<[\t ]*file://\\)\\(.*\\)$")
> >           (setq name (match-string 1)
> >                 value (match-string 4))
> >              ;; Need to handle file:///D:/... as generated by OpenLDAP
>
> That's just to break up the long string into lines so it is easier to
> read.  It shouldn't affect the functioning of the lisp code.
>
>
>
> --- End Message ---