bug#976: Please see bug #976 also (and some minor comments)

[Drew Adams]

Hi Thomas,

It would be great if you could also take a look at bug #965
(http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=965), which is
about the Filesets doc in the GNU Emacs manual.


Also, I tried (briefly) to use the more recent version (2.2) on your website
(http://members.a1.net/t.link/CompEmacsFilesets.html), but I was unable to use
it with GNU Emacs (e.g. release 22.2). In particular, I had some problems
byte-compiling. It would be great if the version (1.8.4) in GNU Emacs could be
upgraded.

FWIW, here are a few minor problems I ran into with your version 2.2 (using GNU
Emacs). You might want to take a look:

1. In the defcustom of `filesets-commands': the `igrep' part should be used only
if `igrep' is defined:

("Grep <<selection>>"
     "grep"
     ("-n " filesets-get-quoted-selection " " "<<file-name>>")
     (:textual))
    ,@(and (fboundp 'igrep) ; Do nothing if not defined.
           '(("iGrep <selection>"
              igrep
              (nil filesets-get-selection "<file-list>")
              (:textual :filelist))))

2. In the defcustom for `filesets-menu-path', '("files") should be '("file").
The GNU Emacs version uses nil as the default, which makes `Filesets' a separate
menu-bar menu, but I think it makes more sense to do as you have done: make it a
submenu of the `File' menu.

3. For GNU Emacs, the code in the GNU Emacs version is needed, I think, for the
`eval-and-compile' that defines `filesets-error': `filesets-add-menu' should not
be used, I think.

4. In `filesets-get-selection', I think (and m p) should be (and m p
mark-active).

5. For GNU Emacs at least, the code that uses `beginning-of-buffer' and
`end-of-buffer' should be treated as in the GNU Emacs version.

6. Some doc string typos: `filesets-get-filelist-1': "NAME" -> "ENTRY";
`filesets-set-default(!|+)': spelling.

7. Untested, but I think in `filesets-open' the code should be
(filesets-file-open open-function this name t), not (filesets-file-open
open-function this t). It makes no sense to use `t' for the name, AFAICT, and
there is no call in the file that uses all four args.

8. In `filesets-add-file', (abbreviate-file-name fn t) should be
(abbreviate-file-name fn) for GNU Emacs.

9. In `filesets-build-menu-now', `filesets-add-submenu' should be `add-submenu'
for GNU Emacs (as in the GNU Emacs version).

10. The doc string of `filesets-dired-find-or-display' should be something like
"Find or display the file on this Dired line."

11. FWIW, `filesets-get-filelist-1' is not used anywhere(?). It seems to be a
work in progress.

Thx. I hope someone will have the time to fix this library up a bit. I've
started using filesets recently and I appreciate the feature - thanks. It needs
better doc, though, to help people try it and realize the potential - I think it
has largely gone unnoticed so far by GNU Emacs users. It would be good to have a
little more explanation of the various keywords, preferably with some simple
illustrative examples.

FWIW, I've been playing with filesets in Icicles:
http://www.emacswiki.org/cgi-bin/wiki/Icicles_-_Persistent_Completions#toc3