bug#1066: 23.0.60; (tool-bar-mode -1) in ~/.emacs has no effect with --daemon

[Dan Nicolaescu]

Romain Francoise <romain@orebokech.com> writes:

  > When Emacs is started with --daemon, (tool-bar-mode -1) has no
  > effect when used in ~/.emacs.
  > 
  > To reproduce:
  > 1. echo "(tool-bar-mode -1)" >~/.emacs
  > 2. Start Emacs, note that it has no tool bar, exit
  > 3. emacs --daemon
  > 4. emacsclient -c: the frame has a tool bar when it should not
  > 
  > In the created frame, the first call to M-x tool-bar-mode has no
  > effect.  A second call finally disables the tool bar.

Can you please test this patch:

--- faces.el.~1.425.~   2008-09-24 12:55:17.000000000 -0700
+++ faces.el    2008-10-02 12:39:46.000000000 -0700
@@ -2001,7 +2001,6 @@ Value is the new frame created."
          ;; Make sure the tool-bar is ready to be enabled.  The
          ;; `tool-bar-lines' frame parameter will not take effect
          ;; without this call.
-         (tool-bar-setup frame)
          (if (null visibility-spec)
              (make-frame-visible frame)
            (modify-frame-parameters frame (list visibility-spec)))